From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129697 invoked by alias); 23 Nov 2017 17:50:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129685 invoked by uid 89); 23 Nov 2017 17:50:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-26.2 required=5.0 tests=BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_NUMSUBJECT,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-spam-relays-external:74.125.82.67, H*RU:74.125.82.67, Files, =e5=b0=a7?= X-HELO: mail-wm0-f67.google.com Received: from mail-wm0-f67.google.com (HELO mail-wm0-f67.google.com) (74.125.82.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Nov 2017 17:50:38 +0000 Received: by mail-wm0-f67.google.com with SMTP id 128so18105411wmo.3 for ; Thu, 23 Nov 2017 09:50:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=8YQ51l5b1tG89xitljLnIEzd30fgfuON9Nd1jo14oi4=; b=DfzNK5cVtTRQEXee/JMMP0Uz+SA6Xh/nBWW63RI9MHyDkIT1dZsdk2axlgTtjgcDkw btT46dQE77ndqgwoPWKHNP5DZhcSq4PMGZS02m/jcolxVaZanpn+Puqb6gefyqlZiT5i EbfSWSCeMsuDSVQawGMjLc1s9J2z8311JiVQ/M3ND1N866bk9aVyaIBOuXeGxFmAOd+t BIGcswQDZq/U1Xh2ZKiMojBQ9Tb/XCmtBDWRbsCBSfoDEfDeRVo9DhYw58lAs2D76q+I 90q3Y7UKeDx6M7gkMsGdQmYGk0s2gSj+MJKKxOPfPf3+QArjq5j416fozcv3LMTlq9t8 vkWw== X-Gm-Message-State: AJaThX6BN8/1pa+xqdoreKKeHaBtpQH7n3ITxNZaJ84tKKpZhM7EuFgf L+/LZ0BMBlJQJ6KyEN/ffzw= X-Google-Smtp-Source: AGs4zMYYmZ5Czg5vLdvv/Dq8j9qyHLOP/O69aOIL4marLw4o2Vk1PHeut6p3TgArKY/v/NflJOYwMA== X-Received: by 10.80.217.6 with SMTP id t6mr14870744edj.217.1511459436484; Thu, 23 Nov 2017 09:50:36 -0800 (PST) Received: from 1170ee0b50d5 (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id z1sm16076770edz.17.2017.11.23.09.50.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Nov 2017 09:50:35 -0800 (PST) Date: Thu, 23 Nov 2017 17:50:00 -0000 From: Yao Qi To: Alan Hayward Cc: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH 3/4] Use flexible target descriptors for aarch64 Message-ID: <20171123175034.GJ318@1170ee0b50d5> References: <86h8ugyenj.fsf@gmail.com> <8EE70574-8937-414B-9903-0E427D388B07@arm.com> <86a7zzwrs5.fsf@gmail.com> <86zi7eqps4.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00569.txt.bz2 On 17-11-23 16:19:44, Alan Hayward wrote: > > Files regenerated in patch below: Commit log is the part to be reviewed in the patch review. It is better to post the patch together with the commit log, although the commit log may not be changed. > > > diff --git a/gdb/arch/aarch64.c b/gdb/arch/aarch64.c > index 95d9906f10e660fda99d73a0d2a9d184fd3a7b52..59f9330235e639d44920cab79b595e5266a935ff 100644 > --- a/gdb/arch/aarch64.c > +++ b/gdb/arch/aarch64.c > @@ -17,14 +17,27 @@ > > > #include "aarch64.h" > +#include > +#include > Is it necessary to include string.h? Otherwise, patch is good to me. -- Yao (齐尧)