From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23835 invoked by alias); 21 Nov 2017 21:31:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23823 invoked by uid 89); 21 Nov 2017 21:31:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=BAYES_00,FREEMAIL_FROM,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-wr0-f174.google.com Received: from mail-wr0-f174.google.com (HELO mail-wr0-f174.google.com) (209.85.128.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Nov 2017 21:31:00 +0000 Received: by mail-wr0-f174.google.com with SMTP id o14so12620382wrf.9 for ; Tue, 21 Nov 2017 13:30:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vJUoWk8hy4IJ4+9/icB86Me3tPMo15QtO3Y5Zy13ciI=; b=cjI69+mafe199909mse7jTqWH1gkyzhEREaSDllyq8RdKRoumCfd8ZJC8u0JrS6ao1 mrLRT90h8mVTzA3/JHDuqYVvn8jTHfynonv0QkTj5EzjRjl2DsXBkSSXDNci0m2p1X7r F2rVxcwa4ejcgZUoeYCBy0gQwAsJAupOPbabS4vwkdYyVhupv42IzBsw0+PVeNp2bfVX KiuZ++030ZaO2ayAzL3xiZ+02UBDwU4gVqCb+FIwF58XoKxT0ORJTadvxLiV8W8kGIpb NNX0RwTGwrAyc483CmxA02oYnZBwUeP7i780+bnubPkse5GW0l4QgcbNjtGzCzNC3XLi kLqQ== X-Gm-Message-State: AJaThX6f9tC6eXeKBQND8S6mSi+rswYI+RaIxMaMi5YWg/iHNFvM4eKj mSKB6BG13ReLWZ0ZVsFEajk= X-Google-Smtp-Source: AGs4zMbyHX9lbGl9YS4Lx/dylg+bQEEahZJ+hD1SPqONhNWpVzk6Fr2L4tyljUNkDnzm6D5veQkRnw== X-Received: by 10.223.134.185 with SMTP id 54mr14710873wrx.128.1511299858011; Tue, 21 Nov 2017 13:30:58 -0800 (PST) Received: from localhost ([2a02:c7d:8ead:7d00:95ea:99df:6784:2fa7]) by smtp.gmail.com with ESMTPSA id d71sm1210496wma.7.2017.11.21.13.30.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 21 Nov 2017 13:30:57 -0800 (PST) Date: Tue, 21 Nov 2017 21:31:00 -0000 From: Yao Qi To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] Basic c++ification of varobj Message-ID: <20171121213049.4h5tuq64wakvk6jv@localhost> References: <20171118214606.24468-1-simon.marchi@polymtl.ca> <20171118214606.24468-2-simon.marchi@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171118214606.24468-2-simon.marchi@polymtl.ca> User-Agent: NeoMutt/20161104 (1.7.1) X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00457.txt.bz2 On 17-11-18 16:46:03, Simon Marchi wrote: > > /* If 1, the -var-update always recomputes the value in the > current thread and frame. Otherwise, variable object is > always updated in the specific scope/thread/frame. */ > - int floating; > + int floating = 0; > > /* Flag that indicates validity: set to 0 when this varobj_root refers > to symbols that do not exist anymore. */ > - int is_valid; > + int is_valid = 1; Since we do the change, can we change these fields to bool? > @@ -114,27 +113,27 @@ struct varobj_dynamic > used to decide if dynamic varobj should recompute their children. > In the event that the frontend never asked for the children, we > can avoid that. */ > - int children_requested; > + int children_requested = 0; > Likewise. Otherwise, it is good to me. -- Yao