From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-143572-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 101753 invoked by alias); 21 Nov 2017 16:50:26 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 101740 invoked by uid 89); 21 Nov 2017 16:50:26 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=
X-HELO: rock.gnat.com
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Nov 2017 16:50:24 +0000
Received: from localhost (localhost.localdomain [127.0.0.1])	by filtered-rock.gnat.com (Postfix) with ESMTP id 27CFD1164EA;	Tue, 21 Nov 2017 11:50:23 -0500 (EST)
Received: from rock.gnat.com ([127.0.0.1])	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)	with LMTP id 0eMZ24LYkaiT; Tue, 21 Nov 2017 11:50:23 -0500 (EST)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1])	by rock.gnat.com (Postfix) with ESMTP id EC09A1164E7;	Tue, 21 Nov 2017 11:50:22 -0500 (EST)
Received: by joel.gnat.com (Postfix, from userid 1000)	id 45AF287459; Tue, 21 Nov 2017 08:50:21 -0800 (PST)
Date: Tue, 21 Nov 2017 16:50:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gdb.ada/minsyms.exp: Don't hardcode the variable's address
Message-ID: <20171121165021.53tzinuyifqpcmy3@adacore.com>
References: <1511280661-14725-1-git-send-email-palves@redhat.com> <1511280661-14725-2-git-send-email-palves@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1511280661-14725-2-git-send-email-palves@redhat.com>
User-Agent: NeoMutt/20170113 (1.7.2)
X-SW-Source: 2017-11/txt/msg00444.txt.bz2

> This new testcase has a test that fails like this here:
> 
>   $1 = (<data variable, no debug info> *) 0x60208c <some_minsym>
>   (gdb) FAIL: gdb.ada/minsyms.exp: print &some_minsym
> 
> The problem is that the testcase hardcodes an expected address for the
> "some_minsym" variable, which obviously isn't stable.
> 
> Fix that by expecting $hex instead.
> 
> gdb/testsuite/ChangeLog:
> 2017-11-21  Pedro Alves  <palves@redhat.com>
> 
> 	* gdb.ada/minsyms.exp: Accept any address for 'some_minsym'.

Gaaah. Head-slapping myself on that one.

Thanks for fixing. Obviously OK :).

-- 
Joel