Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <qiyaoltc@gmail.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] [AArch64] Remove tag from address for watchpoint
Date: Thu, 09 Nov 2017 21:20:00 -0000	[thread overview]
Message-ID: <20171109212009.GE318@1170ee0b50d5> (raw)
In-Reply-To: <f3957df2b1c653a50390eb844437030d@polymtl.ca>

On 17-11-09 16:08:40, Simon Marchi wrote:
> 
> There's gdbarch_addr_bits_remove already as well, I don't know if that has
> the same goal.
> 

Nowadays, it only used for code,

# On some machines there are bits in addresses which are not really
# part of the address, but are used by the kernel, the hardware, etc.
# for special purposes.  gdbarch_addr_bits_remove takes out any such bits so
# we get a "real" address such as one would find in a symbol table.
# This is used only for addresses of instructions, and even then I'm
# not sure it's used in all contexts.  It exists to deal with there
# being a few stray bits in the PC which would mislead us, not as some
# sort of generic thing to handle alignment or segmentation (it's
# possible it should be in TARGET_READ_PC instead).
m:CORE_ADDR:addr_bits_remove:CORE_ADDR addr:addr::core_addr_identity::0

arm and mips reuses the LSB of PC to indicate the execution state change,
arm <-> thumb.  gdbarch_addr_bits_remove for arm and mips clears the LSB
of PC.  However, this gdbarch method can't be used for data address.
armv8 tagged pointer/address can be used for both code and data address.

-- 
Yao (齐尧)


  reply	other threads:[~2017-11-09 21:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-26  8:29 [PATCH 0/3 v2] [AArch64] Support tagged pointer Yao Qi
2017-10-26  8:30 ` [PATCH 1/3] [AArch64 Linux] Get rid of top byte from tagged address on memory access Yao Qi
2017-11-09 20:24   ` Pedro Alves
2017-10-26  8:30 ` [PATCH 3/3] [AArch64] Remove tag from address for watchpoint Yao Qi
2017-11-09 20:30   ` Pedro Alves
2017-11-09 21:08     ` Simon Marchi
2017-11-09 21:20       ` Yao Qi [this message]
2017-11-09 21:09     ` Yao Qi
2017-11-09 22:25       ` Pedro Alves
2017-10-26  8:30 ` [PATCH 2/3] [AArch64] Adjust breakpoint on tagged address Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171109212009.GE318@1170ee0b50d5 \
    --to=qiyaoltc@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox