From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38388 invoked by alias); 1 Nov 2017 15:38:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38373 invoked by uid 89); 1 Nov 2017 15:38:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=me!, Overall, admit, H*Ad:U*keiths X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 01 Nov 2017 15:38:13 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 752B056C0F; Wed, 1 Nov 2017 11:38:12 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id GOTAypFe4MtL; Wed, 1 Nov 2017 11:38:12 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 4416356A5A; Wed, 1 Nov 2017 11:38:12 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 5EE3683060; Wed, 1 Nov 2017 08:38:10 -0700 (PDT) Date: Wed, 01 Nov 2017 15:38:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: Keith Seitz , gdb-patches@sourceware.org Subject: Re: [PATCH 25/40] Introduce lookup_name_info and generalize Ada's FULL/WILD name matching Message-ID: <20171101153810.dc5r27oen5edfwbe@adacore.com> References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-26-git-send-email-palves@redhat.com> <596E6C31.1060908@redhat.com> <918c8d65-4c5d-7c04-c2a3-736b7a20d454@redhat.com> <1fa29e48-cbcd-0b88-41ad-f2bd05650b00@redhat.com> <16094f7b-9416-5cda-78fb-7a8d48043e66@redhat.com> <9ab010e3-5873-494b-4296-2c46f847f080@redhat.com> <2b13a06f-d6d5-45d1-c0a0-0efb289a9131@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2b13a06f-d6d5-45d1-c0a0-0efb289a9131@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2017-11/txt/msg00016.txt.bz2 Hi Pedro, > This patch touches the Ada code a good deal. It's main goal is > to generalize Ada's FULL/WILD name matching, so that C++ can do > something very similar. Let me know if you'd like to review it. > I've been holding on moving forward with this > series because this is a central patch on top of which the > rest of the series sits on. Thanks for drawing my attention to this patch. Overall, it looks pretty neat :) and it starts a nice simplification of some of the code in ada-lang. Thank you! I admit I didn't read the patch in complete details, but enough to understand how it works and convince myself that it should actually work. I've also run it through our testsuites and found no regressions, neither with this patch, nor the series as a whole. So, to summarize, this looks good to me! -- Joel