From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105192 invoked by alias); 16 Oct 2017 03:22:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105182 invoked by uid 89); 16 Oct 2017 03:22:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=anticipated X-HELO: gproxy5-pub.mail.unifiedlayer.com Received: from gproxy5-pub.mail.unifiedlayer.com (HELO gproxy5-pub.mail.unifiedlayer.com) (67.222.38.55) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Oct 2017 03:22:53 +0000 Received: from cmgw3 (unknown [10.0.90.84]) by gproxy5.mail.unifiedlayer.com (Postfix) with ESMTP id 15C00140575 for ; Sun, 15 Oct 2017 21:22:52 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id N3Np1w0052f2jeq013NsP1; Sun, 15 Oct 2017 21:22:52 -0600 X-Authority-Analysis: v=2.2 cv=H76r+6Qi c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=02M-m0pO-4AA:10 a=Rby3zQSgcWPp42GfNToA:9 Received: from 184-96-33-178.hlrn.qwest.net ([184.96.33.178]:40760 helo=bapiya.localdomain) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1e3vzM-003xuJ-QB for gdb-patches@sourceware.org; Sun, 15 Oct 2017 21:22:48 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Subject: [RFA 0/4] finish command constification Date: Mon, 16 Oct 2017 03:22:00 -0000 Message-Id: <20171016032239.24561-1-tom@tromey.com> X-BWhitelist: no X-Exim-ID: 1e3vzM-003xuJ-QB X-Source-Sender: 184-96-33-178.hlrn.qwest.net (bapiya.localdomain) [184.96.33.178]:40760 X-Source-Auth: tom+tromey.com X-Email-Count: 9 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-SW-Source: 2017-10/txt/msg00411.txt.bz2 This series completes my command constification efforts. This turned out to be much simpler than I had anticipated; partly because I started automating some of the changes, and partly because C++ makes some incremental refactorings simpler -- as discussed before, in this case by allowing the introduction of const overloads. This series touches some files I can't compile. I made a best effort to inspect them for const correctness; but it's hard to be sure. Given the experience of this series as a whole, I think it is safe to say that any required changes will be minimal. These patches point out that a number of spots in gdb were not really const-correct. For example there was code like: some_command ((char *) "a constant"), ...) These weren't actually unsafe but nevertheless were ugly. Regression tested by the buildbot. Tom