From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49443 invoked by alias); 13 Oct 2017 20:29:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 49033 invoked by uid 89); 13 Oct 2017 20:29:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:static., HContent-Transfer-Encoding:8bit X-HELO: mail-wr0-f173.google.com Received: from mail-wr0-f173.google.com (HELO mail-wr0-f173.google.com) (209.85.128.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Oct 2017 20:29:49 +0000 Received: by mail-wr0-f173.google.com with SMTP id j14so1817952wre.8 for ; Fri, 13 Oct 2017 13:29:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=iI9LuChCHpKBlw89CEDrhh6/uIrlUDBi2hn9ARkFVLA=; b=gR3GdtaKWz3OHFIq/CYtKyKjMwU8fegPpnxL2IdKrZPQuQRhAxq84Bnhps2Zaf8uDB BWnEFsodbozDxbOQJgGZfSC3IPdRFdb8ajMIZACxXxgk8rgSxB7SSzdvuOOeloU5ZXSW MurzE4oAeYpZJOOfK8Trah1umZQ1/wQvwmqZFN1TNg7scNfhSEEyH/AJDF7T2yJ46VyI acce6WwSBcuNikr88m8eNRsATL0NfeSR7p/7PYKnGBjGcvwJGq+6L1+/OaE5gSbppqgX P6zJV83d6BsMxpLYxeZgtWhZ4bPTbwiiqtsM2KsifUOgdykjzSvxyM7HcE6DaSI7qaj3 rkYQ== X-Gm-Message-State: AMCzsaX8Ozbz2VI+fiCKDNm4iAa7jafyR7HX1CBMMo0CkxxgWZKkWeoo yEgpneN4sE9xe/LxGLQjOYM= X-Google-Smtp-Source: AOwi7QCux/mEpQWQaBHgSQQ1PHNpXCO4EHNOupUuqwRHu/nKTEwPRETdWf2e+Oo+7P2mN5GfpgBYfQ== X-Received: by 10.223.198.134 with SMTP id j6mr2216265wrg.213.1507926587374; Fri, 13 Oct 2017 13:29:47 -0700 (PDT) Received: from 1170ee0b50d5 (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id w62sm1152742wmb.32.2017.10.13.13.29.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Oct 2017 13:29:46 -0700 (PDT) Date: Fri, 13 Oct 2017 20:29:00 -0000 From: Yao Qi To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] ada: Use std::string in print_dynamic_range_bound Message-ID: <20171013202945.GL8425@1170ee0b50d5> References: <1507902347-7971-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1507902347-7971-1-git-send-email-simon.marchi@ericsson.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00372.txt.bz2 On 17-10-13 09:45:47, Simon Marchi wrote: > Replace this usage of GROW_VECT with an std::string. I don't think > there's a reason for this variable to be static, other than it was > cumbersome to manage its lifetime (i.e. use a cleanup) before. > > Tested by comparing the gdb.ada/*.exp test results before and after the > patch. > > gdb/ChangeLog: > > * ada-typeprint.c (print_dynamic_range_bound): Use std::string. Patch is good to me. -- Yao (齐尧)