From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127756 invoked by alias); 11 Oct 2017 16:27:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127115 invoked by uid 89); 11 Oct 2017 16:27:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=credited, Hx-languages-length:985 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Oct 2017 16:27:51 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AFB01356E6; Wed, 11 Oct 2017 16:27:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com AFB01356E6 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=kevinb@redhat.com Received: from pinnacle.lan (ovpn-116-131.phx2.redhat.com [10.3.116.131]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 83CE217CF2; Wed, 11 Oct 2017 16:27:50 +0000 (UTC) Date: Wed, 11 Oct 2017 16:27:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Pedro Alves , Mark Rages Subject: Re: [PATCH] Re: Flash memory size not aligned to address Message-ID: <20171011092749.6ffd39b2@pinnacle.lan> In-Reply-To: <77f0b922-94a8-57a7-32a2-9007a6efff78@redhat.com> References: <20171007144252.05e2b69e@pinnacle.lan> <20171009105111.1a44f9e9@pinnacle.lan> <20171011005613.56c1cac9@pinnacle.lan> <684fd87f-3a01-0725-6b75-bb4bd4aad367@redhat.com> <20171011085355.78e0466e@pinnacle.lan> <77f0b922-94a8-57a7-32a2-9007a6efff78@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00301.txt.bz2 On Wed, 11 Oct 2017 17:11:17 +0100 Pedro Alves wrote: > On 10/11/2017 04:53 PM, Kevin Buettner wrote: > > > I gather it too late to amend it now, right? (Since git commit --amend > > only works on the most recent commit.) > > Right, it's too late, but the reason is we don't allow history > rewrites of the upstream repo; we only allow fast-forward merges > to keep history linear -- even if it were the most recent commit, > you wouldn't be able to push it. (And it's possible to amend > more than one commit.) The closest would be to revert the patch, and > reapply the original patch with author fixed. (Not sure it's > worth complicating git history a bit, but it's easy enough to > do if desired.) Thanks for the explanation. Unless someone strenuously objects, I'll leave it as it is. As noted earlier, Mark is credited in both the ChangeLog as well as in the commit comment. Thanks again, Kevin