From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61462 invoked by alias); 10 Oct 2017 23:03:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 61451 invoked by uid 89); 10 Oct 2017 23:03:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=breaker X-HELO: mail-pf0-f173.google.com Received: from mail-pf0-f173.google.com (HELO mail-pf0-f173.google.com) (209.85.192.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Oct 2017 23:03:28 +0000 Received: by mail-pf0-f173.google.com with SMTP id m28so97190pfi.11 for ; Tue, 10 Oct 2017 16:03:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=LvbUQm8YkSLwG0HqYUBsl80w601/DlKNrcZHwB6bbUQ=; b=K9OiDd0i+QtpI0KpzhRATMyv5HQpJ1qMVudQftvLVoudcIvMiSDrXJWOoS8W2QX2/r 3G6SxivHoyMa52I+zLrel41MHUTDJknsMF+SkV3j5swxk/sArnrvsqILYQp99GhkA1f3 CYH3J3+1uHh+0I1RU1Te0RHSS97FQ1ari27RApib/UdKLoui0PHdhlLktihxm7G0fzT2 u4ZFAN6uGtlzwl0Y8Ym67BOapF1SQS8p1d1cf/dc/fBAjdPE90BKFnaa7286LIN2XPH/ HeFlblDMs7kBEjnUxhNMvTgEnHImdSYayHQqo7qgNjvGNcl5Bu1z6ZPctfanmkRosYeU nUfQ== X-Gm-Message-State: AMCzsaWkQjz30muVreHptNYrAvgtkO1sbkjILMBV59vSnn9BjhWMtDbS gNkNIaBky/os9IjJNZyQNUU= X-Google-Smtp-Source: AOwi7QAyLAufsvfhtfLrKJfDWXS1Y3QlekfBPh6EpwoYhAUJ9pX7SzPOBAZTN43WPECHhBkyXikpsw== X-Received: by 10.99.156.26 with SMTP id f26mr13710549pge.433.1507676606850; Tue, 10 Oct 2017 16:03:26 -0700 (PDT) Received: from localhost (g248.61-45-56.ppp.wakwak.ne.jp. [61.45.56.248]) by smtp.gmail.com with ESMTPSA id 204sm20898002pgf.59.2017.10.10.16.03.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Oct 2017 16:03:26 -0700 (PDT) Date: Tue, 10 Oct 2017 23:03:00 -0000 From: Stafford Horne To: Doug Evans Cc: Simon Marchi , GDB patches , Openrisc , Mike Frysinger Subject: Re: [PATCH v5 3/6] sim: or1k: add or1k target to sim Message-ID: <20171010230323.GD2958@lianli.shorne-pla.net> References: <001a114a9bbe18b046055b2055bc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <001a114a9bbe18b046055b2055bc@google.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00265.txt.bz2 On Mon, Oct 09, 2017 at 05:15:08PM +0000, Doug Evans wrote: > Simon Marchi writes: > > On 2017-10-05 09:49 AM, Stafford Horne wrote: > > > This adds the OpenRISC 32-bit sim target. The OpenRISC sim is a CGEN > > > based sim so the bulk of the code is generated from the .cpu files by > > > CGEN. The engine decode and execute logic in mloop uses scache with > > > pseudo-basic-block extraction and supports both full and fast (switch) > > > modes. > > > > > > The sim does not implement an mmu at the moment. The sim does implement > > > fpu instructions via the common sim-fpu implementation. > > > > > > sim/ChangeLog: > > > > > > 2017-09-13 Stafford Horne > > > Peter Gavin > > > > > > * configure.tgt: Add or1k sim. > > > * or1k/Makefile.in: New file. > > > * or1k/configure.ac: New file. > > > * or1k/mloop.in: New file. > > > * or1k/or1k-sim.h: New file. > > > * or1k/or1k.c: New file. > > > * or1k/sim-if.c: New file. > > > * or1k/sim-main.h: New file. > > > * or1k/traps.c: New file. > > > ... > > > > > > +#define CHECK_SPR_FIELD(GROUP, INDEX, FIELD, test) \ > > > + do { \ > > > + USI field = GET_H_##SYS##_##INDEX##_##FIELD (); \ > > > + if (!(test)) { \ > > > + sim_io_eprintf(sd, "WARNING: unsupported %s field in %s register: 0x%x\n", \ > > > > 80 columns. > > fwiw, I don't mind the odd >80 column limit breaker. > Moving the string to the next line may just work, > but if it doesn't it's fine by me to just leave it. Thanks for this and the other comments. I will get them fixed up and a new version sent. -Stafford