From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90762 invoked by alias); 9 Oct 2017 18:12:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90753 invoked by uid 89); 9 Oct 2017 18:12:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Oct 2017 18:12:17 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6EE7156237; Mon, 9 Oct 2017 14:12:16 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id FVCWOurH9VDq; Mon, 9 Oct 2017 14:12:16 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 5678D560D1; Mon, 9 Oct 2017 14:12:16 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id D329480372; Mon, 9 Oct 2017 14:12:15 -0400 (EDT) Date: Mon, 09 Oct 2017 18:12:00 -0000 From: Joel Brobecker To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [RFC][08/19] Target FP: Use target format throughout expression parsing Message-ID: <20171009181215.tx5pxfnpuxt7ikcy@adacore.com> References: <20170905182110.3ED3BD8086F@oc3748833570.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170905182110.3ED3BD8086F@oc3748833570.ibm.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2017-10/txt/msg00233.txt.bz2 One C++ thing I did notice but forgot to report... > +floatformat_from_string (const struct floatformat *fmt, gdb_byte *out, > + std::string in) Again, to be double-checked, but I think you want to pass the argument by reference in this case. Otherwise, you may end up having an overhead with might not be necessary due to the creation of a copy of the string being passed as argument here. -- Joel