From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91064 invoked by alias); 26 Sep 2017 00:08:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91050 invoked by uid 89); 26 Sep 2017 00:08:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*r:sk:static., HContent-Transfer-Encoding:8bit X-HELO: mail-wr0-f179.google.com Received: from mail-wr0-f179.google.com (HELO mail-wr0-f179.google.com) (209.85.128.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Sep 2017 00:08:42 +0000 Received: by mail-wr0-f179.google.com with SMTP id r74so10623782wrb.13 for ; Mon, 25 Sep 2017 17:08:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=+VxMIFipFszgxqmMnKZ6L93WfRq0O5FOpmcQiiDne6w=; b=ATlznGHI0H8ktWs/9fab6Hlwsv3JFNRbbzxgQUVCO8S89iD4Fh0vPIjvnuNwKwttr7 u0ahaE6tBC8C7oOsgzFwIhGyFy3DI6+1gbzciH85cIt0HikdOxgDCIuj2+Rag0MA8jQl lYy+ylBxv6ZoR6EqgPAVmZGTplbngdX6jDexCSNvb1eZUnj8foccYgFzrlpGcb2tE73R YtQIMvYNToeqnSulbWzw5MjNpjlXHSrVrgTMBLYWPPMs7oP0hEZfTK4VuUnLqXKt8E1r pBifjDMGhGv/of/eLOtZwQiw8R3IYAdzLwlMh1J1HAcFdNR/1aJZ5pKK2aZdZRwXfOEe uIYA== X-Gm-Message-State: AHPjjUiP6Aa5TGCVcnotV1gqcz30wDuQwZaTW5F7GUlmDFlrO+ju10S+ ryrszwZFtEMT6LexPM6XTTu2Tw== X-Google-Smtp-Source: AOwi7QAKLF3k4WCZjgpXs/Vecwqyos9nSH06Xh3unbC6GOBuh8RO8T5g/eJddJywn6SR7Hw3767jAw== X-Received: by 10.223.163.154 with SMTP id l26mr7581725wrb.42.1506384520366; Mon, 25 Sep 2017 17:08:40 -0700 (PDT) Received: from 1170ee0b50d5 (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id 10sm8696495wrt.59.2017.09.25.17.08.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Sep 2017 17:08:39 -0700 (PDT) Date: Tue, 26 Sep 2017 00:08:00 -0000 From: Yao Qi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 0/5] remove cleanups from regcache Message-ID: <20170926000838.GI8425@1170ee0b50d5> References: <20170924024608.4346-1-tom@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170924024608.4346-1-tom@tromey.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00763.txt.bz2 On 17-09-23 20:46:03, Tom Tromey wrote: > This series removes the remaining cleanups from regcache and related > code. > > First, it removes regcache_xmalloc and regcache_xfree in favor of > using plain new and delete everywhere. These were already used under > the hood; this just removes a layer of indirection. > > Second, the main patch, #3, removes a cleanup by using > std::unique_ptr. > > The final two patches remove some cleanups locally in regcache.c by > using standard techniques. > > Regression tested by the buildbot. > > Tom > Hi Tom, I gave comments to one patch, but the rest of them are good to me. I wanted to remove cleanup from regcache for a while, but don't have a chance. Thanks for doing this. -- Yao (齐尧)