From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90479 invoked by alias); 25 Sep 2017 20:04:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90298 invoked by uid 89); 25 Sep 2017 20:04:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=fighting, H*r:sk:static., HContent-Transfer-Encoding:8bit X-HELO: mail-wr0-f169.google.com Received: from mail-wr0-f169.google.com (HELO mail-wr0-f169.google.com) (209.85.128.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Sep 2017 20:04:12 +0000 Received: by mail-wr0-f169.google.com with SMTP id r74so9816247wrb.13 for ; Mon, 25 Sep 2017 13:04:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Wg75Ffjz/weTFMRbmUU6cm294ejbRFfAYzUJoVgMzzg=; b=WkVdsZaVXvJnuIRlBIHfmaO7NiCydWGTC8DgH5DyZVSqmdInkAQFEoQYnkefGqdpV8 1huMXXBrAdEDfKG6dE8REt1dn9doZaatOtp7UXOxZe0f+7DSF8xQPjdheqR72z6aumKQ 3U5jnnlKY184Isw1OFzuwydE/lBpNOgQsjz31R2XR1ytlMjJd+xKNiaLT5h1aRXP1Hfu m/7k8pL+oUcbFIFb7fZwDhM0LEyt70Kti/BPH5+hGhJg5W03m4Qcdog2c/QZ4jeTne4L D+6RBlvDw30BqlEXTtwPjG2Cl8ygxRKyjkQuo7IRGqRCB0ASGugOmzGTwya2pgXazAgy Z1DA== X-Gm-Message-State: AHPjjUi3Xu7it+Pyl3R6M3/8ysoS5tBVD0AgfaKKgbNC9nKOUmcDU0hU NlZspl56iOy2R28Kf5mCjZNohg== X-Google-Smtp-Source: AOwi7QAZLs4QiU/i2DE9dlaQcfeFiFwMxR7TVR4XLyEvw4rJhgRBLOKQzhx4eHm9/IqEaoaeJHpZ9g== X-Received: by 10.223.185.5 with SMTP id k5mr6959757wrf.189.1506369850504; Mon, 25 Sep 2017 13:04:10 -0700 (PDT) Received: from 1170ee0b50d5 (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id 30sm10663389wry.34.2017.09.25.13.04.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Sep 2017 13:04:09 -0700 (PDT) Date: Mon, 25 Sep 2017 20:04:00 -0000 From: Yao Qi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 4/5] Remove make_cleanup_regcache_invalidate Message-ID: <20170925200408.GH8425@1170ee0b50d5> References: <20170924024608.4346-1-tom@tromey.com> <20170924024608.4346-5-tom@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170924024608.4346-5-tom@tromey.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00761.txt.bz2 [I am in the travel, and fighting with jet-lag. Forgive me if I make any stupid mistakes.] On 17-09-23 20:46:07, Tom Tromey wrote: > > - regcache_invalidate (reg->regcache, reg->regnum); > -} > + ~regcache_invalidator () > + { > + if (m_regcache != nullptr) > + regcache_invalidator (m_regcache, m_regnum); m_regcache->invalidate (m_regnum)? I don't see why we need to call ctor in dtor. -- Yao (齐尧)