From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53675 invoked by alias); 21 Sep 2017 05:40:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53579 invoked by uid 89); 21 Sep 2017 05:40:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:4087 X-HELO: gproxy2-pub.mail.unifiedlayer.com Received: from gproxy2-pub.mail.unifiedlayer.com (HELO gproxy2-pub.mail.unifiedlayer.com) (69.89.18.3) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Sep 2017 05:40:09 +0000 Received: from cmgw2 (unknown [10.0.90.83]) by gproxy2.mail.unifiedlayer.com (Postfix) with ESMTP id C242E1E0CD0 for ; Wed, 20 Sep 2017 23:40:07 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id C5g41w01k2f2jeq015g7da; Wed, 20 Sep 2017 23:40:07 -0600 X-Authority-Analysis: v=2.2 cv=dZfw5Tfe c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=2JCJgTwv5E4A:10 a=zstS-IiYAAAA:8 a=HhPj2fO_ZwD9eKQoMHcA:9 a=QEarHM8bDYpLPXe1:21 a=Gx9bXrKcZvLVP5-Z:21 a=4G6NA9xxw8l3yy4pmD5M:22 Received: from 75-166-76-94.hlrn.qwest.net ([75.166.76.94]:36574 helo=bapiya.Home) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1dutkw-00118R-Ja; Wed, 20 Sep 2017 23:10:34 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFA 37/67] Constify some commands in record.c Date: Thu, 21 Sep 2017 05:40:00 -0000 Message-Id: <20170921051023.19023-38-tom@tromey.com> In-Reply-To: <20170921051023.19023-1-tom@tromey.com> References: <20170921051023.19023-1-tom@tromey.com> X-BWhitelist: no X-Exim-ID: 1dutkw-00118R-Ja X-Source-Sender: 75-166-76-94.hlrn.qwest.net (bapiya.Home) [75.166.76.94]:36574 X-Source-Auth: tom+tromey.com X-Email-Count: 42 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-SW-Source: 2017-09/txt/msg00575.txt.bz2 ChangeLog 2017-09-20 Tom Tromey * record.c (cmd_record_delete, cmd_record_stop, cmd_record_save) (cmd_record_goto_begin, cmd_record_goto_end, get_insn_number) (get_context_size, no_chunk, get_insn_history_modifiers) (cmd_record_insn_history, get_call_history_modifiers) (cmd_record_call_history): Constify. --- gdb/ChangeLog | 8 ++++++++ gdb/record.c | 36 ++++++++++++++++++++---------------- 2 files changed, 28 insertions(+), 16 deletions(-) diff --git a/gdb/record.c b/gdb/record.c index 59fb240..a1d0f3c 100644 --- a/gdb/record.c +++ b/gdb/record.c @@ -272,7 +272,7 @@ cmd_record_start (char *args, int from_tty) of replay until the end. */ static void -cmd_record_delete (char *args, int from_tty) +cmd_record_delete (const char *args, int from_tty) { require_record_target (); @@ -298,7 +298,7 @@ cmd_record_delete (char *args, int from_tty) /* Implement the "stoprecord" or "record stop" command. */ static void -cmd_record_stop (char *args, int from_tty) +cmd_record_stop (const char *args, int from_tty) { struct target_ops *t; @@ -354,7 +354,8 @@ info_record_command (char *args, int from_tty) static void cmd_record_save (char *args, int from_tty) { - char *recfilename, recfilename_buffer[40]; + const char *recfilename; + char recfilename_buffer[40]; require_record_target (); @@ -401,7 +402,7 @@ cmd_record_goto (char *arg, int from_tty) /* The "record goto begin" command. */ static void -cmd_record_goto_begin (char *arg, int from_tty) +cmd_record_goto_begin (const char *arg, int from_tty) { if (arg != NULL && *arg != '\0') error (_("Junk after argument: %s."), arg); @@ -413,7 +414,7 @@ cmd_record_goto_begin (char *arg, int from_tty) /* The "record goto end" command. */ static void -cmd_record_goto_end (char *arg, int from_tty) +cmd_record_goto_end (const char *arg, int from_tty) { if (arg != NULL && *arg != '\0') error (_("Junk after argument: %s."), arg); @@ -425,7 +426,7 @@ cmd_record_goto_end (char *arg, int from_tty) /* Read an instruction number from an argument string. */ static ULONGEST -get_insn_number (char **arg) +get_insn_number (const char **arg) { ULONGEST number; const char *begin, *end, *pos; @@ -446,9 +447,10 @@ get_insn_number (char **arg) /* Read a context size from an argument string. */ static int -get_context_size (char **arg) +get_context_size (const char **arg) { - char *pos; + const char *pos; + char *end; int number; pos = skip_spaces (*arg); @@ -456,13 +458,15 @@ get_context_size (char **arg) if (!isdigit (*pos)) error (_("Expected positive number, got: %s."), pos); - return strtol (pos, arg, 10); + long result = strtol (pos, &end, 10); + *arg = end; + return result; } /* Complain about junk at the end of an argument string. */ static void -no_chunk (char *arg) +no_chunk (const char *arg) { if (*arg != 0) error (_("Junk after argument: %s."), arg); @@ -471,10 +475,10 @@ no_chunk (char *arg) /* Read instruction-history modifiers from an argument string. */ static gdb_disassembly_flags -get_insn_history_modifiers (char **arg) +get_insn_history_modifiers (const char **arg) { gdb_disassembly_flags modifiers; - char *args; + const char *args; modifiers = 0; args = *arg; @@ -549,7 +553,7 @@ command_size_to_target_size (unsigned int size) /* The "record instruction-history" command. */ static void -cmd_record_insn_history (char *arg, int from_tty) +cmd_record_insn_history (const char *arg, int from_tty) { require_record_target (); @@ -612,10 +616,10 @@ cmd_record_insn_history (char *arg, int from_tty) /* Read function-call-history modifiers from an argument string. */ static int -get_call_history_modifiers (char **arg) +get_call_history_modifiers (const char **arg) { int modifiers; - char *args; + const char *args; modifiers = 0; args = *arg; @@ -666,7 +670,7 @@ get_call_history_modifiers (char **arg) /* The "record function-call-history" command. */ static void -cmd_record_call_history (char *arg, int from_tty) +cmd_record_call_history (const char *arg, int from_tty) { int flags, size; -- 2.9.4