From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [RFA 35/67] Constify commands maint.c, plus maintenance_print_type
Date: Thu, 21 Sep 2017 05:40:00 -0000 [thread overview]
Message-ID: <20170921051023.19023-36-tom@tromey.com> (raw)
In-Reply-To: <20170921051023.19023-1-tom@tromey.com>
ChangeLog
2017-09-20 Tom Tromey <tom@tromey.com>
* typeprint.c (maintenance_print_type): Constify.
* maint.c (maintenance_dump_me, maintenance_demangle)
(maintenance_time_display, maintenance_info_sections)
(maintenance_print_statistics, maintenance_deprecate)
(maintenance_undeprecate): Constify.
(maintenance_do_deprecate): Constify. Use std::string.
(maintenance_selftest): Constify.
* gdbtypes.h (maintenance_print_type): Constify.
---
gdb/ChangeLog | 11 +++++++++++
gdb/gdbtypes.h | 2 +-
gdb/maint.c | 39 +++++++++++++++------------------------
gdb/typeprint.c | 2 +-
4 files changed, 28 insertions(+), 26 deletions(-)
diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h
index 9d9b09f..8d6fd9b 100644
--- a/gdb/gdbtypes.h
+++ b/gdb/gdbtypes.h
@@ -1931,7 +1931,7 @@ extern int is_scalar_type_recursive (struct type *);
extern int class_or_union_p (const struct type *);
-extern void maintenance_print_type (char *, int);
+extern void maintenance_print_type (const char *, int);
extern htab_t create_copied_types_hash (struct objfile *objfile);
diff --git a/gdb/maint.c b/gdb/maint.c
index b540d1c..6c0dec2 100644
--- a/gdb/maint.c
+++ b/gdb/maint.c
@@ -48,19 +48,13 @@ static void maintenance_command (char *, int);
static void maintenance_internal_error (char *args, int from_tty);
-static void maintenance_demangle (char *, int);
-
-static void maintenance_time_display (char *, int);
-
static void maintenance_space_display (char *, int);
static void maintenance_info_command (char *, int);
-static void maintenance_info_sections (char *, int);
-
static void maintenance_print_command (char *, int);
-static void maintenance_do_deprecate (char *, int);
+static void maintenance_do_deprecate (const char *, int);
/* Set this to the maximum number of seconds to wait instead of waiting forever
in target_wait(). If this timer times out, then it generates an error and
@@ -88,7 +82,7 @@ maintenance_command (char *args, int from_tty)
#ifndef _WIN32
static void
-maintenance_dump_me (char *args, int from_tty)
+maintenance_dump_me (const char *args, int from_tty)
{
if (query (_("Should GDB dump core? ")))
{
@@ -140,13 +134,13 @@ maintenance_demangler_warning (char *args, int from_tty)
"mt demangler-warning" which artificially creates an internal gdb error. */
static void
-maintenance_demangle (char *args, int from_tty)
+maintenance_demangle (const char *args, int from_tty)
{
printf_filtered (_("This command has been moved to \"demangle\".\n"));
}
static void
-maintenance_time_display (char *args, int from_tty)
+maintenance_time_display (const char *args, int from_tty)
{
if (args == NULL || *args == '\0')
printf_unfiltered (_("\"maintenance time\" takes a numeric argument.\n"));
@@ -354,7 +348,7 @@ print_objfile_section_info (bfd *abfd,
}
static void
-maintenance_info_sections (char *arg, int from_tty)
+maintenance_info_sections (const char *arg, int from_tty)
{
if (exec_bfd)
{
@@ -385,7 +379,7 @@ maintenance_info_sections (char *arg, int from_tty)
}
}
else
- bfd_map_over_sections (exec_bfd, print_bfd_section_info, arg);
+ bfd_map_over_sections (exec_bfd, print_bfd_section_info, (void *) arg);
}
if (core_bfd)
@@ -394,12 +388,12 @@ maintenance_info_sections (char *arg, int from_tty)
printf_filtered (" `%s', ", bfd_get_filename (core_bfd));
wrap_here (" ");
printf_filtered (_("file type %s.\n"), bfd_get_target (core_bfd));
- bfd_map_over_sections (core_bfd, print_bfd_section_info, arg);
+ bfd_map_over_sections (core_bfd, print_bfd_section_info, (void *) arg);
}
}
static void
-maintenance_print_statistics (char *args, int from_tty)
+maintenance_print_statistics (const char *args, int from_tty)
{
print_objfile_statistics ();
print_symbol_bcache_statistics ();
@@ -525,7 +519,7 @@ maintenance_translate_address (char *arg, int from_tty)
offered. */
static void
-maintenance_deprecate (char *args, int from_tty)
+maintenance_deprecate (const char *args, int from_tty)
{
if (args == NULL || *args == '\0')
{
@@ -535,12 +529,11 @@ enclosed in quotes.\n"));
}
maintenance_do_deprecate (args, 1);
-
}
static void
-maintenance_undeprecate (char *args, int from_tty)
+maintenance_undeprecate (const char *args, int from_tty)
{
if (args == NULL || *args == '\0')
{
@@ -549,7 +542,6 @@ the command you want to undeprecate.\n"));
}
maintenance_do_deprecate (args, 0);
-
}
/* You really shouldn't be using this. It is just for the testsuite.
@@ -560,14 +552,14 @@ the command you want to undeprecate.\n"));
replacement. */
static void
-maintenance_do_deprecate (char *text, int deprecate)
+maintenance_do_deprecate (const char *text, int deprecate)
{
struct cmd_list_element *alias = NULL;
struct cmd_list_element *prefix_cmd = NULL;
struct cmd_list_element *cmd = NULL;
- char *start_ptr = NULL;
- char *end_ptr = NULL;
+ const char *start_ptr = NULL;
+ const char *end_ptr = NULL;
int len;
char *replacement = NULL;
@@ -591,8 +583,7 @@ maintenance_do_deprecate (char *text, int deprecate)
if (end_ptr != NULL)
{
len = end_ptr - start_ptr;
- start_ptr[len] = '\0';
- replacement = xstrdup (start_ptr);
+ replacement = savestring (start_ptr, len);
}
}
}
@@ -955,7 +946,7 @@ show_per_command_cmd (char *args, int from_tty)
/* The "maintenance selftest" command. */
static void
-maintenance_selftest (char *args, int from_tty)
+maintenance_selftest (const char *args, int from_tty)
{
selftests::run_tests (args);
}
diff --git a/gdb/typeprint.c b/gdb/typeprint.c
index c82e623..8ee44af 100644
--- a/gdb/typeprint.c
+++ b/gdb/typeprint.c
@@ -629,7 +629,7 @@ print_type_scalar (struct type *type, LONGEST val, struct ui_file *stream)
and whatis_command(). */
void
-maintenance_print_type (char *type_name, int from_tty)
+maintenance_print_type (const char *type_name, int from_tty)
{
struct value *val;
struct type *type;
--
2.9.4
next prev parent reply other threads:[~2017-09-21 5:40 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 5:16 [RFA 00/67] Simple add_cmd constification Tom Tromey
2017-09-21 5:11 ` [RFA 05/67] Constify two functions in valprint.c Tom Tromey
2017-09-21 5:13 ` [RFA 28/67] Constify some commands in record-btrace.c Tom Tromey
2017-09-21 7:02 ` Metzger, Markus T
2017-09-21 5:13 ` [RFA 04/67] Constify info_probes_dtrace_command Tom Tromey
2017-09-21 12:48 ` Sergio Durigan Junior
2017-09-21 5:13 ` [RFA 10/67] Constify some functions in psymtab.c Tom Tromey
2017-09-21 5:13 ` [RFA 14/67] Constify core_file_command Tom Tromey
2017-09-21 5:13 ` [RFA 25/67] Constify some commands in symfile.c Tom Tromey
2017-09-21 5:13 ` [RFA 18/67] Constify interpreter_exec_cmd Tom Tromey
2017-09-21 5:13 ` [RFA 07/67] Constify two functions in cp-abi.c Tom Tromey
2017-09-21 5:13 ` [RFA 03/67] Constify not_just_help_class_command Tom Tromey
2017-09-21 5:13 ` [RFA 09/67] Constify display_tib Tom Tromey
2017-09-21 5:13 ` [RFA 16/67] Constify some functions in memattr.c Tom Tromey
2017-09-21 5:13 ` [RFA 12/67] Constify maintenance_cplus_namespace Tom Tromey
2017-09-21 5:15 ` [RFA 21/67] Constify commands in cli-dump.c Tom Tromey
2017-09-21 5:15 ` [RFA 15/67] Constify show_convenience Tom Tromey
2017-09-21 5:15 ` [RFA 20/67] Constify some commands in cli-cmds.c Tom Tromey
2017-09-21 5:16 ` [RFA 26/67] Constify new_ui_command Tom Tromey
2017-09-21 5:16 ` [RFA 11/67] Constify first_component_command Tom Tromey
2017-09-21 5:16 ` [RFA 01/67] Add add_cmd function overloads Tom Tromey
2017-09-21 7:02 ` Metzger, Markus T
2017-09-21 10:25 ` Pedro Alves
2017-09-23 4:14 ` Tom Tromey
2017-09-23 4:14 ` Tom Tromey
2017-09-26 12:11 ` Pedro Alves
2017-09-27 14:44 ` Tom Tromey
2017-09-21 10:25 ` Pedro Alves
2017-09-23 4:18 ` Tom Tromey
2017-09-23 4:30 ` Tom Tromey
2017-09-23 4:49 ` Tom Tromey
2017-09-26 12:12 ` Pedro Alves
2017-09-27 14:42 ` Tom Tromey
2017-09-21 5:16 ` [RFA 22/67] Constify user_defined_command Tom Tromey
2017-09-21 5:16 ` [RFA 02/67] Constify add_cmd gdb_bfd.c Tom Tromey
2017-09-21 5:17 ` [RFA 13/67] Constify maintenance_print_user_registers Tom Tromey
2017-09-21 5:17 ` [RFA 06/67] Constify dump_arc_instruction_command Tom Tromey
2017-09-21 5:17 ` [RFA 23/67] Constify some commands in cli-logging.c Tom Tromey
2017-09-21 5:17 ` [RFA 17/67] Constify cmd_record_full_restore Tom Tromey
2017-09-21 7:02 ` Metzger, Markus T
2017-09-21 5:17 ` [RFA 27/67] Constify some commands in symmisc.c Tom Tromey
2017-09-21 5:17 ` [RFA 29/67] Constify some commands in skip.c Tom Tromey
2017-09-21 5:17 ` [RFA 08/67] Constify two functions in linux-fork.c Tom Tromey
2017-09-21 5:31 ` [RFA 19/67] Constify maintenance_print_target_stack Tom Tromey
2017-09-21 5:31 ` [RFA 24/67] Constify some commands in spu-tdep.c Tom Tromey
2017-09-21 5:39 ` [RFA 49/67] Constify some commands in btrace.c Tom Tromey
2017-09-21 7:02 ` Metzger, Markus T
2017-09-21 11:11 ` Pedro Alves
2017-09-21 13:06 ` Metzger, Markus T
2017-09-21 13:47 ` Pedro Alves
2017-09-21 16:53 ` Metzger, Markus T
2017-09-23 4:28 ` Tom Tromey
2017-09-26 8:15 ` Metzger, Markus T
2017-09-21 5:39 ` [RFA 48/67] Constify delete_bookmark_command Tom Tromey
2017-09-21 5:39 ` [RFA 51/67] Constify info_probes_stap_command Tom Tromey
2017-09-21 12:48 ` Sergio Durigan Junior
2017-09-21 5:39 ` [RFA 52/67] Constify save_gdb_index_command Tom Tromey
2017-09-21 5:39 ` [RFA 33/67] Constify some commands in target-descriptions.c Tom Tromey
2017-09-21 5:39 ` [RFA 31/67] Constify some commands in tui.c Tom Tromey
2017-09-21 5:39 ` [RFA 50/67] Constify unset_exec_wrapper_command Tom Tromey
2017-09-21 5:39 ` [RFA 32/67] Constify maintenance_print_dummy_frames Tom Tromey
2017-09-21 5:40 ` [RFA 56/67] Constify demangle_command Tom Tromey
2017-09-21 5:40 ` [RFA 64/67] Constify some commands in inferior.c Tom Tromey
2017-09-21 5:40 ` Tom Tromey [this message]
2017-09-21 10:06 ` [RFA 35/67] Constify commands maint.c, plus maintenance_print_type Pedro Alves
2017-09-23 4:32 ` Tom Tromey
2017-09-21 5:40 ` [RFA 55/67] Constify maintenance_info_program_spaces_command Tom Tromey
2017-09-21 5:40 ` [RFA 36/67] Constify some commands in source.c Tom Tromey
2017-09-21 5:40 ` [RFA 45/67] Constify cd_command Tom Tromey
2017-09-21 12:48 ` Sergio Durigan Junior
2017-09-21 5:40 ` [RFA 53/67] Constify maintenance_print_reggroups Tom Tromey
2017-09-21 5:40 ` [RFA 67/67] Constify find_command Tom Tromey
2017-09-21 5:40 ` [RFA 62/67] Constify some commands in printcmd.c Tom Tromey
2017-09-21 5:40 ` [RFA 47/67] Constify some commands in remote.c Tom Tromey
2017-09-21 5:40 ` [RFA 63/67] Constify some commands in regcache.c Tom Tromey
2017-09-21 5:40 ` [RFA 37/67] Constify some commands in record.c Tom Tromey
2017-09-21 7:02 ` Metzger, Markus T
2017-09-23 4:05 ` Tom Tromey
2017-09-21 10:00 ` Pedro Alves
2017-09-23 4:05 ` Tom Tromey
2017-09-23 4:29 ` Tom Tromey
2017-09-21 5:40 ` [RFA 38/67] Constify some linespec functions Tom Tromey
2017-09-21 10:04 ` Pedro Alves
2017-09-23 4:03 ` Tom Tromey
2017-09-26 12:17 ` Pedro Alves
2017-09-21 5:40 ` [RFA 65/67] Constify some commands in symtab.c Tom Tromey
2017-09-21 5:40 ` [RFA 44/67] Constify some commands in thread.c Tom Tromey
2017-09-21 5:40 ` [RFA 66/67] Constify some commands in ada-tasks.c Tom Tromey
2017-09-21 5:40 ` [RFA 34/67] Constify unwind_command Tom Tromey
2017-09-21 5:40 ` [RFA 54/67] Constify some commands in compile.c Tom Tromey
2017-09-21 5:40 ` [RFA 46/67] Constify some commands in mips-tdep.c Tom Tromey
2017-09-21 5:41 ` [RFA 41/67] Constify some commands in remote-fileio.c Tom Tromey
2017-09-21 5:41 ` [RFA 39/67] Constify some commands in ax-gdb.c Tom Tromey
2017-09-21 5:41 ` [RFA 59/67] Constify some commands in infcmd.c Tom Tromey
2017-09-21 9:56 ` Pedro Alves
2017-09-21 5:41 ` [RFA 43/67] Constify some commands in probes.c Tom Tromey
2017-09-21 12:47 ` Sergio Durigan Junior
2017-09-21 5:41 ` [RFA 60/67] Constify some commands in macrocmd.c Tom Tromey
2017-09-21 5:41 ` [RFA 58/67] Constify some commands in i386-tdep.c Tom Tromey
2017-09-21 5:42 ` [RFA 61/67] Constify some commands in breakpoint.c Tom Tromey
2017-09-21 9:56 ` Pedro Alves
2017-09-21 13:20 ` Patrick Monnerat
2017-09-21 5:42 ` [RFA 57/67] Constify add_symbol_file_from_memory_command Tom Tromey
2017-09-21 5:42 ` [RFA 42/67] Constify some commands in exec.c, plus symbol_file_command Tom Tromey
2017-09-21 5:42 ` [RFA 40/67] Constify some commands in tracepoint.c Tom Tromey
2017-09-21 10:03 ` Pedro Alves
2017-09-23 4:34 ` Tom Tromey
2017-09-21 5:42 ` [RFA 30/67] Constify tui_reg_command Tom Tromey
2017-09-21 10:26 ` [RFA 00/67] Simple add_cmd constification Pedro Alves
2017-09-26 12:19 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170921051023.19023-36-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox