From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: simon.marchi@polymtl.ca (Simon Marchi)
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC][02/19] Target FP: Simplify floatformat_from_type
Date: Mon, 18 Sep 2017 19:01:00 -0000 [thread overview]
Message-ID: <20170918190131.E5D12D835CB@oc3748833570.ibm.com> (raw)
In-Reply-To: <af503ff0ff491144f47af6d538b9b022@polymtl.ca> from "Simon Marchi" at Sep 18, 2017 06:20:53 PM
Simon Marchi wrote:
> Since this is where we do the division by
> TARGET_CHAR_BIT, and therefore assume (implicitly) that bit is a
> multiple of TARGET_CHAR_BIT, I think this is where the assert should be
> added. To avoid adding them everywhere, we could make
> arch_type/init_type take a size in bits, and do the division and assert
> there.
I agree, this seems the best solution. And it makes more sense for all
the type-creation interfaces to use size in bits instead of the
mixture we have now. I'll come up with a patch to do that.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2017-09-18 19:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 18:20 Ulrich Weigand
2017-09-17 15:29 ` Simon Marchi
2017-09-18 11:49 ` Ulrich Weigand
2017-09-18 16:21 ` Simon Marchi
2017-09-18 19:01 ` Ulrich Weigand [this message]
2017-09-20 16:30 ` Ulrich Weigand
2017-09-27 17:08 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170918190131.E5D12D835CB@oc3748833570.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox