From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] eval.c:evaluate_subexp_standard: Factor out function call handling
Date: Tue, 05 Sep 2017 09:43:00 -0000 [thread overview]
Message-ID: <20170905094312.GC8425@1170ee0b50d5> (raw)
In-Reply-To: <1504563210-2521-1-git-send-email-palves@redhat.com>
On 17-09-04 23:13:30, Pedro Alves wrote:
> While working on the no-debug-info debugging improvements, I found
> evaluate_subexp_standard's function call code unnecessarily long and
> hard to navigate and debug. The use of goto doesn't help either.
It is good to shorten the long function. Patch looks good to me.
> +/* Evaluate a function call. The function to be called is in
> + argvec[0]. FUNCTION_NAME is the name of the function, if known.
s/argvec/ARGVEC/ ?
and better to document that argvec[1] - argvec[nargs] are arguments
passed to the function.
--
Yao (é½å°§)
next prev parent reply other threads:[~2017-09-05 9:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 22:13 Pedro Alves
2017-09-05 9:43 ` Yao Qi [this message]
2017-09-05 10:19 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170905094312.GC8425@1170ee0b50d5 \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox