From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43217 invoked by alias); 4 Sep 2017 09:22:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 42982 invoked by uid 89); 4 Sep 2017 09:22:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:clients, H*r:sk:static., HContent-Transfer-Encoding:8bit X-HELO: mail-wr0-f173.google.com Received: from mail-wr0-f173.google.com (HELO mail-wr0-f173.google.com) (209.85.128.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Sep 2017 09:22:19 +0000 Received: by mail-wr0-f173.google.com with SMTP id 40so12960953wrv.5 for ; Mon, 04 Sep 2017 02:22:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Iy5KWUgYGcm3yJ+fGdWKoJw83VLa1cIdbV25L0CSJkg=; b=qNSzKStBhErnzTQLeUBpj4LtTdG/H75SLsK9DlO43dftpDDLV6N45fW/I8/AOtnWrs 7CpLuAmghOloFPVha8hnKk1Ud3aeLCvelBnpxT8/gDNQsEDLliNtUBbuppKEx1tttOvg VeUyofYUGgkKwqfhFw8E/ZeL79XYHCAXXGtoXi9evZBu0A3CXYnSl+JxWbCSemuplmQj 6f4v/aJuTTiVr7yMW425srTBD/cisGApsLFCGUBA9PJwoq7yzdbEWV5f77lUc7hdJdzh UN9eeMgba90ZsqlWzYlTFKKycoRDiPP+TUA/r3mS9WPR9wfiNBX8jQm5Mm6BK61QeEFd L04w== X-Gm-Message-State: AHPjjUjThWjB/PADF6hv/mV8rXB7wGbBeceAi9xnlnmqTni4d+OBkOzw sHlmy+EWWV09Eg== X-Google-Smtp-Source: ADKCNb5rUEpJ2bik8XFjqtRUuMGm6GUY4Ds8KVLOSS/CJLMQ1przDNxnw2DpVDhLc8RyTwoJKtBXVw== X-Received: by 10.223.196.18 with SMTP id v18mr941812wrf.280.1504516937596; Mon, 04 Sep 2017 02:22:17 -0700 (PDT) Received: from 1170ee0b50d5 (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id a6sm146065wme.16.2017.09.04.02.22.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Sep 2017 02:22:17 -0700 (PDT) Date: Mon, 04 Sep 2017 09:22:00 -0000 From: Yao Qi To: Tim Wiederhake Cc: gdb-patches@sourceware.org, Bernhard Heckel Subject: Re: [PATCH v3 5/6] Fortran: Enable setting breakpoint on nested functions. Message-ID: <20170904092212.GA8425@1170ee0b50d5> References: <1502449611-8865-1-git-send-email-tim.wiederhake@intel.com> <1502449611-8865-6-git-send-email-tim.wiederhake@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1502449611-8865-6-git-send-email-tim.wiederhake@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00031.txt.bz2 On 17-08-11 13:06:50, Tim Wiederhake wrote: > From: Bernhard Heckel > > Like in Ada, we want to be able to set a breakpoint on nested functions, > called "contained routines" in Fortran. > > xxxx-yy-zz Bernhard Heckel > > gdb/ChangeLog: > * dwarf2read.c (add_partial_symbol): Enable for Fortran as well. > (new_symbol_full): Same. > (add_partial_subprogram): Check for subprogram tag. > > gdb/testsuite/ChangeLog: > * gdb.fortran/nested-funcs.exp: Set breakpoint on contained routines. Patch is good to me. -- Yao (齐尧)