From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8147 invoked by alias); 19 Jul 2017 00:13:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8136 invoked by uid 89); 19 Jul 2017 00:13:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Jul 2017 00:13:03 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 97DD43D94D for ; Wed, 19 Jul 2017 00:13:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 97DD43D94D Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=kevinb@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 97DD43D94D Received: from pinnacle.lan (ovpn-116-35.phx2.redhat.com [10.3.116.35]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 64872782BB for ; Wed, 19 Jul 2017 00:13:02 +0000 (UTC) Date: Wed, 19 Jul 2017 00:13:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Subject: Re: [PATCH v2 3/7] Documentation for gdb.thread_from_thread_handle Message-ID: <20170718171300.6064c285@pinnacle.lan> In-Reply-To: References: <20170408224959.67164a27@pinnacle.lan> <20170408230700.3754771e@pinnacle.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00268.txt.bz2 On Fri, 05 May 2017 00:01:31 -0400 Simon Marchi wrote: > > +@defun gdb.thread_from_thread_handle (thread_handle) > > +Return the thread object corresponding to the thread handle, > > +@var{thread_handle}, a thread library specific data structure such as > > The comma before @var{thread_handle} feels unnecessary. And I think you > could shorten it to "... corresponding to @var{thread_handle}, ..." > without loss of clarity. I like your proposed (re)wording. Since it's okay with Eli, that's what I've incorporated into the new patch which I will post shortly. Kevin