From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46781 invoked by alias); 29 Jun 2017 12:51:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 46700 invoked by uid 89); 29 Jun 2017 12:51:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:10.10.0 X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Jun 2017 12:51:01 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 41C9F81593; Thu, 29 Jun 2017 14:50:59 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wX--W2zlGnUs; Thu, 29 Jun 2017 14:50:59 +0200 (CEST) Received: from chelles.act-europe.fr (chelles.act-europe.fr [10.10.0.160]) by smtp.eu.adacore.com (Postfix) with ESMTP id 2F38C81490; Thu, 29 Jun 2017 14:50:59 +0200 (CEST) Received: by chelles.act-europe.fr (Postfix, from userid 560) id 2DBCB1EA0068; Thu, 29 Jun 2017 14:50:59 +0200 (CEST) Date: Thu, 29 Jun 2017 12:51:00 -0000 From: Jerome Guitton To: Sergio Durigan Junior Cc: GDB Patches Subject: Re: [PATCH] PR cli/21688: Fix multi-line/inline command differentiation Message-ID: <20170629125059.GG24541@adacore.com> References: <20170629020527.468-1-sergiodj@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170629020527.468-1-sergiodj@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2017-06/txt/msg00790.txt.bz2 Sergio Durigan Junior (sergiodj@redhat.com): > The problem happens because, on cli/cli-script.c:process_next_line, > GDB is not using the command line string to identify which command to > run, but it instead using the 'struct cmd_list_element *' that is > obtained by using the mentioned string. The problem with that is that > the 'struct cmd_list_element *' doesn't have any information on > whether the command issued by the user is a multi-line or inline one. Indeed. Thank you for catching this bug!