From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35390 invoked by alias); 28 Jun 2017 21:40:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 35375 invoked by uid 89); 28 Jun 2017 21:40:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.1 required=5.0 tests=BAYES_00,FREEMAIL_FROM,MIME_CHARSET_FARAWAY,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Guild, HContent-Transfer-Encoding:8bit X-HELO: mail-wm0-f45.google.com Received: from mail-wm0-f45.google.com (HELO mail-wm0-f45.google.com) (74.125.82.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Jun 2017 21:40:10 +0000 Received: by mail-wm0-f45.google.com with SMTP id w126so65262128wme.0 for ; Wed, 28 Jun 2017 14:40:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=HYANX0XNfBsbxScIzbslFy3W43XeLEKc9xRqeRNMLjI=; b=krXEiMch+OOMj4WqT9mQWozwlExmnrpXWq7k5TCwAuk/JbcHL212arzYyP07tacL4u nf3SFv/xqwvNaaP/FS1ewGVp9vwASaEwgat5o/74LHmPI2HgrKBmJpGP4MTZRsxKlfYl OD1DleIBB4pw4eHVW4B9V9ftoq4/+XzH6AK5w5Bia88ukPaNl/KGd1s59wVaZUNdLHiC WTI8y7UjimSXpSDYPtRAEdU6gg4uIuINFdFBr4St3V8bHZdQXvUBDmr/bmYfYT7G5xfe 2Y2G9gNiFkZVAJ8k0iUpgHYPUkxbuvu5xr+p+yTbfSXuzIrYRCuURmcgYr+pGXA7kVK9 tudQ== X-Gm-Message-State: AKS2vOyiyHgChoygfxqqdpcnihEMrSI4Na+TEO3Q3+uNfe4rjjK68YRr O8c+ttun0tE5XA== X-Received: by 10.28.50.200 with SMTP id y191mr2314451wmy.104.1498686008830; Wed, 28 Jun 2017 14:40:08 -0700 (PDT) Received: from localhost ([2a02:c7d:8ead:7d00:cd4c:ef8b:7838:db06]) by smtp.gmail.com with ESMTPSA id r24sm2166145wrc.21.2017.06.28.14.40.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Jun 2017 14:40:08 -0700 (PDT) Date: Wed, 28 Jun 2017 21:40:00 -0000 From: Yao Qi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 09/40] Rename make_symbol_completion_list_fn -> symbol_completer Message-ID: <20170628214005.f32ek3cdt2vtlh4l@localhost> References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-10-git-send-email-palves@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=unknown-8bit Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1496406158-12663-10-git-send-email-palves@redhat.com> User-Agent: NeoMutt/20161104 (1.7.1) X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00777.txt.bz2 On 17-06-02 13:22:07, Pedro Alves wrote: > "make_symbol_completion_list_fn" is odly named when you look at a list > of "standard" completers, like the Python/Guild completer lists > adjusted by this patch. Rename / move it to completers.h/c, for > consistency. > > gdb/ChangeLog: > yyyy-mm-dd Pedro Alves > > * completer.c (symbol_completer): New function, based on > make_symbol_completion_list_fn. > * completer.h (symbol_completer): New declaration. > * guile/scm-cmd.c (cmdscm_completers): Adjust. > * python/py-cmd.c (completers): Adjust. > * symtab.c (make_symbol_completion_list_fn): Delete. > * symtab.h (make_symbol_completion_list_fn): Delete. > * cli/cli-decode.c (add_cmd): Adjust. Patch is good to me. -- Yao (齐尧)