Re: ping: [patch] aarch64: PR 19806: watchpoints: false negatives + PR 20207 contiguous ones

Pedro Alves
2018-04-20T15:59:57Z

On 04/20/2018 04:54 PM, Eli Zaretskii wrote:

>> diff --git a/gdb/NEWS b/gdb/NEWS
>> index 25c404bfc37..38043c4ff2e 100644
>> --- a/gdb/NEWS
>> +++ b/gdb/NEWS
>> @@ -35,6 +35,16 @@ SH-5/SH64 ELF sh64-*-elf*, SH-5/SH64 support in sh*
>> SH-5/SH64 running GNU/Linux SH-5/SH64 support in sh*-*-linux*
>> SH-5/SH64 running OpenBSD SH-5/SH64 support in sh*-*-openbsd*
>>
>> +* Aarch64/Linux hardware watchpoints improvements
>> +
>> + Hardware watchpoints on unaligned addresses are now properly
>> + supported when running Linux kernel 4.10 or higher: read and access
>> + watchpoints are no longer spuriously missed, and all watchpoints
>> + lengths between 1 and 8 bytes are supported. On older kernels,
>> + watchpoints set on unaligned addresses are no longer missed, with
>> + the tradeoff that there is a possibility of false hits being
>> + reported.
>
> I wonder whether we need this NEWS entry. We don't normally call out
> bugfixes there, do we?

Yao requested one in an earlier review. I'm borderline about it
myself, with no strong opinion.
There's a tradeoff here, which may be worth advertising, and the
mention of kernel version might be useful too.

Thanks,
Pedro Alves