From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52777 invoked by alias); 19 Jun 2017 09:39:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52263 invoked by uid 89); 19 Jun 2017 09:39:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 Jun 2017 09:39:27 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C409F40F0E for ; Mon, 19 Jun 2017 09:39:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C409F40F0E Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jan.kratochvil@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com C409F40F0E Received: from host1.jankratochvil.net (ovpn-116-67.ams2.redhat.com [10.36.116.67]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 015AF77ED6; Mon, 19 Jun 2017 09:39:29 +0000 (UTC) Date: Mon, 19 Jun 2017 09:39:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: Regression: Re: [PATCH 2/6] Code cleanup: dwarf2read.c: Eliminate ::file_write Message-ID: <20170619093927.GA24763@host1.jankratochvil.net> References: <8efc0742-1014-4fe0-6948-f40a9c5c4975@redhat.com> <1497284051-13795-2-git-send-email-palves@redhat.com> <20170618183603.GA1834@host1.jankratochvil.net> <0d3d940c-c6d6-02df-69a0-defdd300f92f@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0d3d940c-c6d6-02df-69a0-defdd300f92f@redhat.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-SW-Source: 2017-06/txt/msg00499.txt.bz2 On Mon, 19 Jun 2017 11:27:46 +0200, Pedro Alves wrote: > On 06/18/2017 07:36 PM, Jan Kratochvil wrote: > > >> @@ -23252,7 +23233,8 @@ public: > >> /* Write the buffer to FILE. */ > >> void file_write (FILE *file) const > >> { > >> - ::file_write (file, m_vec); > >> + if (::fwrite (m_vec.data (), 1, m_vec.size (), file) != m_vec.size ()) > >> + error (_("couldn't write data to file")); > >> } > > > > It is a regression as one needs to multiply vector.size() by sizeof(vector[0]). > > Which is also why I separated determining the memory block boundaries from > > checking the write success. > > No it's not. The fwrite call is no longer in generic code where > the element type is unknown. Here m_vec is a vector of gdb_byte, and > gdb_byte is guaranteed to have sizeof == 1. Ah, OK. So I would like there some: static_assert (sizeof (m_vec[0]) == 1); The file_write template+function is used also in a later patch of that series where sizeof(element) is not 1. I have reimplemented it with ::fwrite in this "v2" series after this your removal but I do not agree with that, IMO it was safer+easier with the template+function you just removed. Jan