Re: Regression: Re: [PATCH 2/6] Code cleanup: dwarf2read.c: Eliminate ::file_write

Jan Kratochvil
2017-06-19T10:03:04Z

On Mon, 19 Jun 2017 11:47:51 +0200, Pedro Alves wrote:
> But as I said, it can't be exactly the
> same as the original one, because it simply wouldn't compile.

I haven't found a benchmark whether the gdb::byte_vector optimization was
really worth complicating the codebase. GDB has more serious performance
problems than such microoptimizations.

One of the goals of the move to C++ was to remove all the GDB-specific
language constructs making it easier to contribute. Now GDB is becoming
written in its own language again, just based on C++ this time.

Jan