From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17558 invoked by alias); 17 Jun 2017 17:35:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17544 invoked by uid 89); 17 Jun 2017 17:35:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 17 Jun 2017 17:35:17 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 21F07C04B317 for ; Sat, 17 Jun 2017 17:35:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 21F07C04B317 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jan.kratochvil@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 21F07C04B317 Received: from host1.jankratochvil.net (ovpn-116-67.ams2.redhat.com [10.36.116.67]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6AFD617124; Sat, 17 Jun 2017 17:35:16 +0000 (UTC) Date: Sat, 17 Jun 2017 17:35:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/6] Code cleanup: dwarf2read.c: Eliminate ::file_write Message-ID: <20170617173443.GA17084@host1.jankratochvil.net> References: <8efc0742-1014-4fe0-6948-f40a9c5c4975@redhat.com> <1497284051-13795-2-git-send-email-palves@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1497284051-13795-2-git-send-email-palves@redhat.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-SW-Source: 2017-06/txt/msg00475.txt.bz2 On Mon, 12 Jun 2017 18:14:07 +0200, Pedro Alves wrote: > There's no real need for all this indirection. > - ::file_write (file, m_vec); > + if (::fwrite (m_vec.data (), 1, m_vec.size (), file) != m_vec.size ()) > + error (_("couldn't write data to file")); Aren't 28 characters with the variable mentioned once easier to write and more bug-proof than to write each time 115 characters mentioning the same variable 3 times? Jan