From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27861 invoked by alias); 8 Jun 2017 05:01:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27734 invoked by uid 89); 8 Jun 2017 05:01:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-12.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=letter X-HELO: mail-pg0-f65.google.com Received: from mail-pg0-f65.google.com (HELO mail-pg0-f65.google.com) (74.125.83.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 08 Jun 2017 05:01:51 +0000 Received: by mail-pg0-f65.google.com with SMTP id f127so3378139pgc.2 for ; Wed, 07 Jun 2017 22:01:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NIBgm5GUpYjIL79tD7oTe9dbI6JToqn5aB2NP5qJ/JM=; b=Owrv376DVvf2F/5924TDzKM4n3LOSpPXioS9yfbUIOjiBQ4KZ18ZN6q09mtUrfN3Ed /pzWO0AqDMeQZYfs01fy9VfBTOZGiU0zZjm1qJ5pXkRN866hMliU+Dm3nY74OOXJs0dZ NX3r+MnCdeovepKMhcMhb8AssuTCXzd1e3oNvONe4hld1LzGrFg8QE+s1QskKq5aVZEs 7EiqlyA1DyXDkEIzINMtjUAYYCVAV+NAYpPXsRhIwnVSEB/u0LoRbNhvIUoTCNWd6CNY EulIhJ+zRu0QzC6nR7DMNKYbCY0ZqVhJqxz+zS0tW9IpQQJYcha5qDu4xEizK8roJW+S 00ig== X-Gm-Message-State: AODbwcBw/2N/JTtRKT34zabHi9hYZvRqw/4UbbeKBeWKy0v3AFp3fz8D DA91uLdExPCwshxcX80= X-Received: by 10.98.54.129 with SMTP id d123mr35412962pfa.197.1496898113997; Wed, 07 Jun 2017 22:01:53 -0700 (PDT) Received: from localhost (g212.61-193-241.ppp.wakwak.ne.jp. [61.193.241.212]) by smtp.gmail.com with ESMTPSA id z66sm7539629pfl.13.2017.06.07.22.01.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 Jun 2017 22:01:53 -0700 (PDT) Date: Thu, 08 Jun 2017 05:01:00 -0000 From: Stafford Horne To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p Message-ID: <20170608050151.GB5971@lianli.shorne-pla.net> References: <0c4f5b59a645a64535e7c8bb0f34b03df805f4e4.1496871270.git.shorne@gmail.com> <83d1af8an1.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83d1af8an1.fsf@gnu.org> User-Agent: Mutt/1.8.0 (2017-02-23) X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00196.txt.bz2 On Thu, Jun 08, 2017 at 05:40:34AM +0300, Eli Zaretskii wrote: > > From: Stafford Horne > > Cc: Stafford Horne > > Date: Thu, 8 Jun 2017 07:15:47 +0900 > > > > --- a/gdb/NEWS > > +++ b/gdb/NEWS > > @@ -3,6 +3,10 @@ > > > > *** Changes since GDB 8.0 > > > > +* GDB now supports dynamically creating arbitrary register groups specified > > + in xml target descriptors. This allows for finer grain grouping of > > + registers on systems with a large amount of registers. > > + > > I'm confused: in the commentary for the patch to the manual you said > the feature existed, but wasn't documented. So why is it mentioned in > NEWS as a new feature? Should we have more documentation changes, if > it's new? Thanks for reviewing. Sorry, you are right its a bit confusing and this second part probably needs some more document changes. There are 2 things going on in those 2 patches. 1. Add docs for the existing feature (listing registers by group name) 2. Add feature to be able to defined more groups based on the XML target description. Ill add docs for (2) and try to make it a bit more clear in my next cover letter. Is the single NEWS entry ok in the end? -Stafford