From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64428 invoked by alias); 24 May 2017 19:37:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 64410 invoked by uid 89); 24 May 2017 19:37:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=5x X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 May 2017 19:37:16 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id CAE352BD6C; Wed, 24 May 2017 15:37:18 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id s-pMn54CCmjq; Wed, 24 May 2017 15:37:18 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 9E7CD2BD5A; Wed, 24 May 2017 15:37:18 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 9562280375; Wed, 24 May 2017 12:37:16 -0700 (PDT) Date: Wed, 24 May 2017 19:37:00 -0000 From: Joel Brobecker To: Eli Zaretskii Cc: Pedro Alves , simon.marchi@polymtl.ca, gdb-patches@sourceware.org Subject: Re: GDB 7.99.91 MinGW compilation error in cli-script.c Message-ID: <20170524193716.5arjibe4s5efvgj7@adacore.com> References: <83fug35v70.fsf@gnu.org> <83y3tt2ow0.fsf@gnu.org> <83vaox2j0w.fsf@gnu.org> <7017128a-7b51-5436-657b-58807d04eb02@redhat.com> <83vaouns1q.fsf@gnu.org> <837f18ohr2.fsf@gnu.org> <54594002-5d70-9ff8-c481-0cbfc8c68c7b@redhat.com> <834lwam7n4.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <834lwam7n4.fsf@gnu.org> User-Agent: NeoMutt/20170113 (1.7.2) X-SW-Source: 2017-05/txt/msg00528.txt.bz2 > Here's the final version; okay to commit? > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index a96e71f..d3a251b 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,3 +1,10 @@ > +2017-05-24 Eli Zaretskii > + > + * common/common-utils.h (REPLACE_TO_STRING) [__MINGW32__]: Define > + to 1 if std::to_string is not available. > + (std::to_string) [REPLACE_TO_STRING]: Provide a replacement > + implementation. Did we consider the option of perhaps only pushing this patch to the 8.0 branch, and require MinGW 5.x for the current master? If we did it that way, it would allow us to avoid remembering that we need to use gdb::to_string instead of std::to_string. -- Joel