From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102344 invoked by alias); 20 May 2017 06:42:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 102328 invoked by uid 89); 20 May 2017 06:42:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=01pm, 01PM X-HELO: mail-pf0-f171.google.com Received: from mail-pf0-f171.google.com (HELO mail-pf0-f171.google.com) (209.85.192.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 20 May 2017 06:42:26 +0000 Received: by mail-pf0-f171.google.com with SMTP id n23so49095003pfb.2 for ; Fri, 19 May 2017 23:42:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zA/o5X/Oe4TD1++NsvwBK7xludZy0w0behbw9uvGWZU=; b=s3lL+0Fsi9RYeTubEiVIUUS4knPVU3ufDF28vSrwXuW8yaOxrZZNF5pxAcsFdFm398 itFqj50AAOjDvVGEh1be4JULj7JUjtBEbFyC9Up9Y+8BFt7ro+bVq9u9d0WNoD2wCWpB jorBkYOCvawoYlx3YWPLyQNKSxFRveBoggYUbjAkL5EgAzYknMHav2/Jkz3uGlbZWd8Q 57/ZUKaPuJ8wqfg89X2z4paM/QSe5df2LlfdDyjMWKkJQu1p8vBVrWa2g/6VEmeejTlc L4QS5ae7crcnRiwNwBGmT+I+0yoXBfAyvqtcf6GihH0fEJ35s2fsiwxFGPMzP2nElC+U rOAA== X-Gm-Message-State: AODbwcD/uMedtt+E/lu2RNimAwX/QhBQ7t/nbAsLceuyr/LztQY46LYc IfE8WjhVSys5fA== X-Received: by 10.99.148.17 with SMTP id m17mr14133988pge.187.1495262548052; Fri, 19 May 2017 23:42:28 -0700 (PDT) Received: from localhost (z209.124-44-183.ppp.wakwak.ne.jp. [124.44.183.209]) by smtp.gmail.com with ESMTPSA id g27sm18601681pfg.63.2017.05.19.23.42.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 19 May 2017 23:42:27 -0700 (PDT) Date: Sat, 20 May 2017 06:42:00 -0000 From: Stafford Horne To: Yao Qi Cc: GDB patches , Openrisc , Franck Jullien Subject: Re: [PATCH v6 1/5] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p Message-ID: <20170520064225.GA2940@lianli.shorne-pla.net> References: <86r307725n.fsf@gmail.com> <20170502154115.GH2724@lianli.shorne-pla.net> <86wp9qt9ty.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86wp9qt9ty.fsf@gmail.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00480.txt.bz2 On Tue, May 09, 2017 at 02:54:01PM +0100, Yao Qi wrote: > Stafford Horne writes: > > > This change is to also allow returning true in the case that the register > > group was registered with gdb with reggroup_add(). This seems like > > something that will be generally required so it was added to the > > target-descriptions definition. If you think not I can make it for > > openrisc only, but I think it makes more sense in tdesc. > > Thanks for the explanation. > > > > > This allows the command like, the below to return the registers for the > > named reggroup. > > > > info reg system > > Some bits are missing, > > - A test case, in which we can define some reggroups "foo" and test > expected "foo" is shown in the output of "maintenance print > reggroups". You can add reggroups in gdb.xml/extra-regs.xml. > > - A test case with live inferior, get a list of support reggroups from > the output of "maint print reggroups", pass each reggroup to "info > reg $group", and test there is no error. > > - Document "info registers". > https://sourceware.org/gdb/current/onlinedocs/gdb/Registers.html > doesn't document the usage "info reg GROUP". We need to add it. > > - Add a news entry, because your patch adds a user visible change. Right, I am working on this, I have most of it done. However, I am thinking to submit this separately from the OpenRISC port. There are more changes required to get this to work as you mention in the (1st) test case above. Currently tdesc supplied reggroups are not added by default, they need to be manually supplied by calling reggroup_add(). I have made a patch to make this automatic. As mentioned I will split this out separate from the OpenRISC patch and do all that is mentioned above. -Stafford