From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8650 invoked by alias); 16 May 2017 21:12:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7752 invoked by uid 89); 16 May 2017 21:12:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:585 X-HELO: mail-wm0-f51.google.com Received: from mail-wm0-f51.google.com (HELO mail-wm0-f51.google.com) (74.125.82.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 16 May 2017 21:12:36 +0000 Received: by mail-wm0-f51.google.com with SMTP id d127so132674585wmf.0 for ; Tue, 16 May 2017 14:12:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2omdKZPDXrJX2qMa68SUk3mvvGyzAQOdNpiLpb+nAcU=; b=Pc7+u3ojzD+TQ06Y2pyebyI4pE3L4a+DT8NS3xTeKoys/h5PO5d8ZAyqBRWeqwX5NC I4KH2B3M8oWg9HYt5H7A9mox2edfojyXDX74BL/Q+V9M+Q9m42kyoUoE9rJe5AaALb8Q 1kVpxMiuaEHGuT4+/WfOoOGlB5zZDE90BdbSJh2Ft/8IeTlUvLFMVBxk10nDts9f5Tup 9adbTeKMFKvlEXG+nbslnDy5OraSVQzXCeY3Vgo4ixCdwJIhDOrXFKtiWktuZBUpY8te +rc0kM8Y9GBc/N0E1F/Dfu0SzVrtxOojhD7oVeo+2KaNj0FeROxIuV9+jkwd+ZIY1OZa pEBQ== X-Gm-Message-State: AODbwcB3udRk1BA/dTQHzNQ9xIBwLIc0AEVXgB28dTDO9SJwvBJgHSy4 lGtHNzlYXuqdqg== X-Received: by 10.28.236.205 with SMTP id h74mr330430wmi.92.1494969157278; Tue, 16 May 2017 14:12:37 -0700 (PDT) Received: from localhost ([2a02:c7d:8e8d:100:1dee:4877:4bfc:e432]) by smtp.gmail.com with ESMTPSA id u76sm3550282wrb.27.2017.05.16.14.12.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 May 2017 14:12:36 -0700 (PDT) Date: Tue, 16 May 2017 21:12:00 -0000 From: Yao Qi To: Andreas Arnez Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 18/19] write_pieced_value: Notify memory_changed observers Message-ID: <20170516211233.74q3emvaeenibkoj@localhost> References: <1494352015-10465-1-git-send-email-arnez@linux.vnet.ibm.com> <1494352015-10465-19-git-send-email-arnez@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494352015-10465-19-git-send-email-arnez@linux.vnet.ibm.com> User-Agent: NeoMutt/20161104 (1.7.1) X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00357.txt.bz2 On 17-05-09 19:46:14, Andreas Arnez wrote: > So far write_pieced_value uses write_memory when writing memory pieces to > the target. However, this is a case where GDB potentially overwrites a > watchpoint value. In such a case write_memory_with_notification should be > used instead, so that memory_changed observers get notified. > > gdb/ChangeLog: > > * dwarf2loc.c (write_pieced_value): When writing the data for a > memory piece, use write_memory_with_notification instead of > write_memory. LGTM. -- Yao