From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88087 invoked by alias); 16 May 2017 21:08:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88077 invoked by uid 89); 16 May 2017 21:08:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.1 required=5.0 tests=BAYES_00,FREEMAIL_FROM,MIME_CHARSET_FARAWAY,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Respect, HContent-Transfer-Encoding:8bit X-HELO: mail-wr0-f177.google.com Received: from mail-wr0-f177.google.com (HELO mail-wr0-f177.google.com) (209.85.128.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 16 May 2017 21:08:14 +0000 Received: by mail-wr0-f177.google.com with SMTP id l9so83751239wre.1 for ; Tue, 16 May 2017 14:08:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=cnrECu0ZB1hZBe+d1ezPZZxlGnVMm1xkiQ6jlmP9D1w=; b=qisiCwf/4eSpLyoQLiWAE9Gvt/4HnK+W7bT8OkmBKpSxIwseyOZK2P4F0qAH0qlMl8 kZhBMRd5FnzKNeun5NIdAINC5iyQBt47TiKwi5wpTe5xYoyP+qxRqu+hFLdboEPUIJZy SwGc0KRBkxIAPMu0GV9K1XQ9qtyEvxuDMZR0waQRMu50yMrPTx/jGaL2vGj9jo2QbNov jIUzvXOhiyhOQyIG5SOFDdWoDQTilOoMdBSXt6j9r4R6sChMc3BgKoqz9W29x+hMBoQY kl3An6/cZOMCIxM3WaVPoowCc4pFJwvjUTC676o7LkDMGLtK6vtA49lODteasMX0PPNH LL3Q== X-Gm-Message-State: AODbwcAbRJx/55YZjWlxgEzR0Ebg7uvzjbreGt9PxYgR4hpiopgJH+Ti MshhswSI6t7ssjaP X-Received: by 10.223.171.238 with SMTP id s101mr8575619wrc.83.1494968895216; Tue, 16 May 2017 14:08:15 -0700 (PDT) Received: from localhost ([2a02:c7d:8e8d:100:1dee:4877:4bfc:e432]) by smtp.gmail.com with ESMTPSA id v52sm2753839wrc.53.2017.05.16.14.08.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 May 2017 14:08:14 -0700 (PDT) Date: Tue, 16 May 2017 21:08:00 -0000 From: Yao Qi To: Andreas Arnez Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 15/19] Respect piece offset for DW_OP_bit_piece Message-ID: <20170516210811.6ddoflqc6ofwd7rr@localhost> References: <1494352015-10465-1-git-send-email-arnez@linux.vnet.ibm.com> <1494352015-10465-16-git-send-email-arnez@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=unknown-8bit Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1494352015-10465-16-git-send-email-arnez@linux.vnet.ibm.com> User-Agent: NeoMutt/20161104 (1.7.1) X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00356.txt.bz2 On 17-05-09 19:46:11, Andreas Arnez wrote: > So far GDB ignores the piece offset of all kinds of DWARF bit > pieces (DW_OP_bit_piece) and treats such pieces as if the offset was zero. > > This is fixed, and an appropriate test is added. > > gdb/ChangeLog: > > * dwarf2loc.c (read_pieced_value): Respect the piece offset, as > given by DW_OP_bit_piece. > (write_pieced_value): Likewise. > > Andreas Arnez > > * gdb.dwarf2/var-access.exp: Add test for composite location with > nonzero piece offsets. LGTM. -- Yao (齐尧)