Re: [PATCH v6 1/5] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p

[Stafford Horne <shorne@gmail.com>]

On Tue, May 09, 2017 at 03:21:43PM +0100, Yao Qi wrote:
> Stafford Horne <shorne@gmail.com> writes:
> >  
> >        if (reggroup == general_reggroup)
> >  	return general_p;
> > +
> > +      if (strcmp (reg->group, reggroup_name (reggroup)) == 0)
> > +	return 1;
> > +
> >      }
> 
> I read the patch again, and find that we can replace the whole block in
> "if (reg != NULL && reg->group != NULL)" with the code this patch adds,
> like this,
> 
>   if (reg != NULL && reg->group != NULL
>       && (strcmp (reg->group, reggroup_name (reggroup)) == 0))
>      return 1;

Thanks,  I was thinking to simply to this as well,  but I left the patch I
inheherited as is.  I will also update the commit log and comment to make
it more clear what is going on.

> -- 
> Yao (齐尧)