From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63995 invoked by alias); 11 May 2017 21:32:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63938 invoked by uid 89); 11 May 2017 21:32:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*r:100 X-HELO: mail-wm0-f50.google.com Received: from mail-wm0-f50.google.com (HELO mail-wm0-f50.google.com) (74.125.82.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 May 2017 21:32:06 +0000 Received: by mail-wm0-f50.google.com with SMTP id u65so6204545wmu.1 for ; Thu, 11 May 2017 14:32:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=HWDmMp5nT7OL40ulNrUWwg3xnHu+9NEvbt2keMgBcmE=; b=d+sdLE+Kkmkng8jqA/8UHA3DyrZ2nnbAxZdDsNG8NtxfV9ZtNyhbswit3DGWTHQAZG UvcbRyWLu8hElUWn9vNCPmv0jjYzl6tdKOdCfG6fylOwMQZfBMlCcOjF/se4UeUIu59t hgynF47luS7FMZMqQM37IjX5RvliWaiY5HCPBSdzA+bvnBmZL0WgIxafwG9/UoTwTbK6 +KBJkbmGR/9+IQ3SYQLGi3pwGWhfZVPGgCF3zhnzD4Ch1PP1UXF4u+AoEIqOfVUF1+ke 7eQbEqo120aMwhCLQrS9gFoWhEpLVZ3KhWQoNfikSlz5TL2F3llJ67TGBNf55Wt1sh4K mtmA== X-Gm-Message-State: AODbwcBdybRNzI3F87OAERQG5uepFRA5p0LVRoFc7XA14161OMpztJZV BcTwX/i90s7/Q9FQ X-Received: by 10.28.144.10 with SMTP id s10mr117279wmd.62.1494538327600; Thu, 11 May 2017 14:32:07 -0700 (PDT) Received: from localhost ([2a02:c7d:8e8d:100:f98c:5f75:db14:bcce]) by smtp.gmail.com with ESMTPSA id w68sm1483513wrb.49.2017.05.11.14.32.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 May 2017 14:32:07 -0700 (PDT) Date: Thu, 11 May 2017 21:32:00 -0000 From: Yao Qi To: Andreas Arnez Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 05/19] gdb/testsuite: Add "get_endianness" convenience proc Message-ID: <20170511213203.fur3vvh7jlhgd73k@localhost> References: <1494352015-10465-1-git-send-email-arnez@linux.vnet.ibm.com> <1494352015-10465-6-git-send-email-arnez@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494352015-10465-6-git-send-email-arnez@linux.vnet.ibm.com> User-Agent: NeoMutt/20161104 (1.7.1) X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00306.txt.bz2 On 17-05-09 19:46:01, Andreas Arnez wrote: > The test suite contains multiple instances of determining the target's > endianness with GDB's "show endian" command. This patch replaces these by > an invocation of a new convenience proc 'get_endianness'. > > gdb/testsuite/ChangeLog: > > * lib/gdb.exp (get_endianness): New proc. > * gdb.arch/aarch64-fp.exp: Use it. > * gdb.arch/altivec-regs.exp: Likewise. > * gdb.arch/e500-regs.exp: Likewise. > * gdb.arch/vsx-regs.exp: Likewise. > * gdb.base/dump.exp: Likewise. > * gdb.base/funcargs.exp: Likewise. > * gdb.base/gnu_vector.exp: Likewise. > * gdb.dwarf2/formdata16.exp: Likewise. > * gdb.dwarf2/implptrpiece.exp: Likewise. > * gdb.dwarf2/nonvar-access.exp: Likewise. > * gdb.python/py-inferior.exp: Likewise. > * gdb.trace/unavailable-dwarf-piece.exp: Likewise. LGTM. -- Yao