From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69074 invoked by alias); 11 May 2017 21:22:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69040 invoked by uid 89); 11 May 2017 21:22:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Quote, H*r:100 X-HELO: mail-wm0-f48.google.com Received: from mail-wm0-f48.google.com (HELO mail-wm0-f48.google.com) (74.125.82.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 May 2017 21:22:33 +0000 Received: by mail-wm0-f48.google.com with SMTP id m123so50658227wma.0 for ; Thu, 11 May 2017 14:22:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nH/YOXAvpeC2mbAgFrS9pvCW8HVhRRz8M1q3q0IEAxs=; b=pwdKmUIuo/5pOuIYO4nXLpHebsDbT0ECOgfVMzqvr+nxda/vG7Gfv7X9BqXpyGWJJi 6sj/B2c85ydVmF3irF6H36X02avl/hWJIA6UTbWwiZ8ge1YfcKCOFQjz8rJ4hho/sRQD UCxMKmQUn3SrTIxBGg9y3U9JGZTcDSEuBG/YdbyCu4oRAOMP5yrQtSlPiBQbm74Pg7Cq M5eG72vo7NB9TAX8nWDxQyFPntyg6WUKAIq0FeRt2f3fb0oiDLd5AE59oFoceCkx/Z2g PfRJyzi11xPh6waEbAczST3Z5T+gQNROdRSDBb4oCL8EEtBti4wF7F+lU+xB0hxBRF1d /uGA== X-Gm-Message-State: AODbwcDmyCkz7G/CBb4YPNL7fJsVOaebFfmqc4akD2jR5wo+HPrKwHtS YDSZiSCJ4gH/Rjy+ X-Received: by 10.28.234.19 with SMTP id i19mr386284wmh.106.1494537754264; Thu, 11 May 2017 14:22:34 -0700 (PDT) Received: from localhost ([2a02:c7d:8e8d:100:f98c:5f75:db14:bcce]) by smtp.gmail.com with ESMTPSA id w18sm1248139wra.34.2017.05.11.14.22.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 May 2017 14:22:33 -0700 (PDT) Date: Thu, 11 May 2017 21:22:00 -0000 From: Yao Qi To: Andreas Arnez Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 01/19] Add test for modifiable DWARF locations Message-ID: <20170511212228.qnta4yo5dx3f4syr@localhost> References: <1494352015-10465-1-git-send-email-arnez@linux.vnet.ibm.com> <1494352015-10465-2-git-send-email-arnez@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494352015-10465-2-git-send-email-arnez@linux.vnet.ibm.com> User-Agent: NeoMutt/20161104 (1.7.1) X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00303.txt.bz2 On 17-05-09 19:45:57, Andreas Arnez wrote: > This adds a test for read/write access to variables with various types of > DWARF locations. It uses register- and memory locations and composite > locations with register- and memory pieces. > > Since the new test calls gdb_test_no_output with commands that contain > braces, it is necessary for string_to_regexp to quote braces as well. > This was not done before. > > gdb/testsuite/ChangeLog: > > * gdb.dwarf2/var-access.c: New file. > * gdb.dwarf2/var-access.exp: New test. > * lib/gdb-utils.exp (string_to_regexp): Quote braces as well. LGTM. -- Yao