From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13996 invoked by alias); 21 Apr 2017 08:52:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13465 invoked by uid 89); 21 Apr 2017 08:52:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=bg, BG, check-in, 9601 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Apr 2017 08:52:10 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C0938341585; Fri, 21 Apr 2017 08:52:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C0938341585 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jan.kratochvil@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com C0938341585 Received: from host1.jankratochvil.net (ovpn-117-182.ams2.redhat.com [10.36.117.182]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 138235C6FB; Fri, 21 Apr 2017 08:52:07 +0000 (UTC) Date: Fri, 21 Apr 2017 08:52:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Cc: Joel Brobecker , Sergio Durigan Junior Subject: [patch+8.0] release branch: Fix: --enable-werror Message-ID: <20170421085204.GA5501@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8t9RHnE3ZwKMSgU+" Content-Disposition: inline User-Agent: Mutt/1.8.0 (2017-02-23) X-SW-Source: 2017-04/txt/msg00593.txt.bz2 --8t9RHnE3ZwKMSgU+ Content-Type: text/plain; charset=iso-2022-jp Content-Disposition: inline Content-length: 622 Hi, gdb-8.0-branch ./configure --enable-werror --enable-targets=all aarch64-tdep.c:3045:13: error: ‘void selftests::aarch64_process_record_test()’ declared ‘static’ but never defined [-Werror=unused-function] arm-tdep.c:9601:13: error: ‘void selftests::arm_record_test()’ declared ‘static’ but never defined [-Werror=unused-function] OK for check-in? Please do not tell me release branches do not support --enable-werror as this is due to a sourcebase bug, not due to some unexpected compiler incompatibility. Sergio: Shouldn't it be also buildbot-tested? Jan --8t9RHnE3ZwKMSgU+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename=1 Content-length: 1127 gdb/ChangeLog 2017-04-21 Jan Kratochvil * aarch64-tdep.c (selftests::aarch64_process_record_test): Make it #if GDB_SELF_TEST. * arm-tdep.c (selftests::arm_record_test): Likewise. diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c index 28c2573..6113621 100644 --- a/gdb/aarch64-tdep.c +++ b/gdb/aarch64-tdep.c @@ -3040,10 +3040,12 @@ aarch64_dump_tdep (struct gdbarch *gdbarch, struct ui_file *file) paddress (gdbarch, tdep->lowest_pc)); } +#if GDB_SELF_TEST namespace selftests { static void aarch64_process_record_test (void); } +#endif /* Suppress warning from -Wmissing-prototypes. */ extern initialize_file_ftype _initialize_aarch64_tdep; diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c index c8fabfb..9ac667f 100644 --- a/gdb/arm-tdep.c +++ b/gdb/arm-tdep.c @@ -9596,10 +9596,12 @@ arm_dump_tdep (struct gdbarch *gdbarch, struct ui_file *file) (unsigned long) tdep->lowest_pc); } +#if GDB_SELF_TEST namespace selftests { static void arm_record_test (void); } +#endif extern initialize_file_ftype _initialize_arm_tdep; /* -Wmissing-prototypes */ --8t9RHnE3ZwKMSgU+--