Re: [PATCH v3] Use std::vector in lm_info_target

Simon Marchi
2017-04-30T00:42:41Z

On 2017-04-29 20:34, Simon Marchi wrote:
> v3 simply updates the patch to the changes made to lm_info_target
> (previously
> lm_info).
>
> Replace the two VEC fields with std::vector.
>
> gdb/ChangeLog:
>
> * solib-target.c (struct lm_info): Add default constructor,
> delete copy constructor and operator=.
> <segment_bases, section_bases>: Change type to
> std::vector<CORE_ADDR>.
> (library_list_start_segment, library_list_start_section,
> library_list_start_library, library_list_end_library,
> solib_target_free_library_list, solib_target_free_so,
> solib_target_relocate_section_addresses): Adjust.

Err I forgot to update the ChangeLog, here it is:

gdb/ChangeLog:

* solib-target.c: Include <vector>
(struct lm_info_target) <~lm_info_target>: Remove.
<segment_bases, section_bases>: Change type to
std::vector<CORE_ADDR>.
(library_list_start_segment, library_list_start_section,
library_list_end_library,
solib_target_relocate_section_addresses): Adjust.

Is the ChangeLog format acceptable for the destructor?

Simon