From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80303 invoked by alias); 8 Apr 2017 09:38:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 80289 invoked by uid 89); 8 Apr 2017 09:38:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=extras, H*RU:209.85.192.196, Hx-spam-relays-external:209.85.192.196 X-HELO: mail-pf0-f196.google.com Received: from mail-pf0-f196.google.com (HELO mail-pf0-f196.google.com) (209.85.192.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 08 Apr 2017 09:38:04 +0000 Received: by mail-pf0-f196.google.com with SMTP id n11so3567297pfg.2 for ; Sat, 08 Apr 2017 02:38:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=FZySbTGiExhCWncBIOfvaodlGOKiyT4SHvbNFD7ha9U=; b=p9WVv91EHVBqzE9N84D+o7+l2u/g92U71FNDcvia+b26ZESkZLuKmX69a5/umG32x4 xivuAHEKK7eY7x59VNYU4MZmLC7M3DEhcbjWqibIM2swAbjabh/5xq3YE6kEVPs34Bih f9U0XIb4/sutXjCkXOJSf/SuOjuCHWMX1pN6k9rs53Ku5WLDkVo6nkaQlEHouXOh3zU6 RhE4Juy30/rOuny4MVirLGVkxWVrUw4m+hXU2Ukj/FNrEN/IjwnXiXA/Zk994BccGRbe 43CAcy49vsPa87OR/1zmgR4dlBzF6KG0iRCAII+m1FPhsY/QZFLCGVmcaS5kuNsGCVsN ug1A== X-Gm-Message-State: AFeK/H2f//7Az9OJ+qnHj4fG4lUeK1TsAucwAGK29oB31cLUxl9kJIyg5/MiEum6+telug== X-Received: by 10.99.177.4 with SMTP id r4mr45482848pgf.16.1491644284953; Sat, 08 Apr 2017 02:38:04 -0700 (PDT) Received: from localhost (z167.124-45-127.ppp.wakwak.ne.jp. [124.45.127.167]) by smtp.gmail.com with ESMTPSA id p68sm13985110pga.6.2017.04.08.02.38.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 08 Apr 2017 02:38:04 -0700 (PDT) Date: Sat, 08 Apr 2017 09:38:00 -0000 From: Stafford Horne To: Yao Qi Cc: gdb-patches@sourceware.org, openrisc@lists.librecores.org Subject: Re: [PATCH v5 2/4] gdb: provide openrisc target description XML files. Message-ID: <20170408093801.GD2194@lianli.shorne-pla.net> References: <7504d4eb6312e41dd98b643c486152d9f5331e05.1489728533.git.shorne@gmail.com> <86mvbv6f1c.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <86mvbv6f1c.fsf@gmail.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00191.txt.bz2 On Tue, Apr 04, 2017 at 10:25:51PM +0100, Yao Qi wrote: > Stafford Horne writes: > > > diff --git a/gdb/features/or1k.xml b/gdb/features/or1k.xml > > new file mode 100644 > > index 0000000..688b340 > > --- /dev/null > > +++ b/gdb/features/or1k.xml > > @@ -0,0 +1,2274 @@ > > + > > + > > + > > + > > + > > + or1k > > + > > 11 features are defined, but your patch 1/4 only checks feature group0. > Does it indicate that only group0 is a required feature? If so, we need > to document it here, > https://sourceware.org/gdb/current/onlinedocs/gdb/Standard-Target-Features.html > > Of course, the debugging stub,like OpenOCD, can provide more features > than GDB required. In GDB, we need only to define required features. I have removed these 11 features and just left the 1. I think its better that the targets provide all the extras. Also, I documented it. I will send the patches. > -- > Yao (齐尧)