RE: [PATCH 15/18] -Wwrite-strings: execute_command calls with string literals

Metzger, Markus T
2017-04-05T07:13:48Z

Hello Pedro,

> All these places would better be calling some API function directly
> instead of going through execute_command & friends...

Ah, and I thought this is the preferred way.

The patch looks good to me. But I'm wondering if we should instead change
execute_command to take a const char *.

Regards,
Markus.

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928