From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106907 invoked by alias); 30 Mar 2017 01:50:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 101368 invoked by uid 89); 30 Mar 2017 01:49:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=sk:extende, deals X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 30 Mar 2017 01:49:21 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ED503624B3 for ; Thu, 30 Mar 2017 01:49:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com ED503624B3 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=sergiodj@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com ED503624B3 Received: from psique.yyz.redhat.com (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9FC275C545; Thu, 30 Mar 2017 01:49:21 +0000 (UTC) From: Sergio Durigan Junior To: GDB Patches Cc: Pedro Alves Subject: [PATCH v5 0/5] Implement the ability to start inferiors with a shell on gdbserver Date: Thu, 30 Mar 2017 01:50:00 -0000 Message-Id: <20170330014915.4894-1-sergiodj@redhat.com> In-Reply-To: <1482464361-4068-1-git-send-email-sergiodj@redhat.com> References: <1482464361-4068-1-git-send-email-sergiodj@redhat.com> X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg00516.txt.bz2 Hi there, This is the fifth iteration of the patch series. You can see the last version here: This version was made to address several comments made by Pedro regarding the last two versions of the series. Various things were changed and improved in this version, including the merge of two commits (the first two commits of the last version are now the first commit of this version) and the addition of a C++ preparation commit, as requested. Here's what has changed: - A bunch of new hooks on fork_inferior, which made it easier to get rid of some of the GDB-specific functions that were being shared with gdbserver (implemented as placeholders). - GDB's remote backend is now setting startup-with-shell on the right place (on extended_remote_create_inferior). - Got rid of the "ui switching" hack; now this is all done on postfork_child_hook. - Wrote more info about the *_update functions on gdbserver/{linux,lynx}-low.c - Added more rationale on the non-existing-program.exp testcase. - Got rid of the inferior_ptid global on gdbserver, which allowed the deletion of some placeholders (inferior_appeared, current_inferior). - Update comments on all *_create_inferior functions on gdbserver. - Improved the code and the comments of handle_v_run, especifically the part that deals with argument parsing. - Created a new program_name variable on gdbserver, which makes it easier to call create_inferior without having to create a copy of the args vector. - Got rid of the pre_fork_inferior function, transforming it into the prefork_hook generic function. - Constified the first argument of create_inferior (const char *program). - Fixed vector iteration on C++ using range-based loop. - Fixed possible problem with stringify_argv, where it was trying to erase a char from a string without knowing if the string wasn't empty. - Created gdb_startup_inferior so that set_executing gets called automatically after startup_inferior. - Improved the entry about the new QStartupWithShell packet on the documentation. - Improved the startup-with-shell.exp testcase, which now doesn't depend on gdbserver and can be run by the native target as well. Tested, and no regressions found.