From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37708 invoked by alias); 8 Mar 2017 05:29:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 37490 invoked by uid 89); 8 Mar 2017 05:29:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=UD:terminal.c, terminal.c, terminalc, H*MI:sk:2017020 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Mar 2017 05:29:40 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 43604C054C38; Wed, 8 Mar 2017 05:29:41 +0000 (UTC) Received: from psique.yyz.redhat.com (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v285Te87010590; Wed, 8 Mar 2017 00:29:40 -0500 From: Sergio Durigan Junior To: GDB Patches Cc: Pedro Alves , Luis Machado Subject: [PATCH v4 0/5] Implement the ability to start inferiors with a shell on gdbserver Date: Wed, 08 Mar 2017 05:29:00 -0000 Message-Id: <20170308052931.25398-1-sergiodj@redhat.com> In-Reply-To: <20170208032257.15443-1-sergiodj@redhat.com> References: <20170208032257.15443-1-sergiodj@redhat.com> X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg00084.txt.bz2 Hi again, This is the fourth version of this patch series. You can look at the last version sent here: This version now has 5 patches instead of 6 because the first patch, which shared gdb/environ.[ch] between GDB and gdbserver, got accepted and pushed upstream. The changes in this version were almost entirely made to address Pedro's reviews (thanks!). Here's the bulk of what changed from v3: - We now check if the necessary headers for some terminal.h features are present on common/common.m4. - Reorganized the job_control part; moved it to the correct patch (2/5 instead of 1/5). - Return the proper value (0) on create_tty_session. - Reformatted the comments on gdbserver/terminal.c. - Renamed the file to "common/job-control.c" instead of "common/common-inflow.c". - Call set_executing after calling fork_inferior, which makes it unnecessary to expand its prototype and accept more arguments. - Removed the "struct ui" hacks on gdbserver; replace them by some new functions that take care of everything from the GDB side. - Fixed use of invalid C++ for "startup_with_shell" variable. - Still declaring "inferior_ptid" on gdbserver/inferiors.c, but added a comment explaining why. - Expanded the comment on {linux,lynx}_update_process and update_thread_lwp. - Constified second argument of fork_inferior. - Improved a few error messages. - Improved some C++ range loops. - Constified a few things and improved comments. - Removed erroneous call to post_fork_inferior on Windows code. - Improved text on NEWS file. - Improved help text for "--startup-with-shell"/"--no-startup-with-shell" parameters on gdbserver. - Moved code to set startup-with-shell packet to the "create_inferior" function on extended remote code. - Fixed a bunch of testcase nits. If you go to the v3 version of the patch, you can see the cover letter as well. This has been tested on BuildBot, and no regressions were found. Thanks,