From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 437 invoked by alias); 1 Mar 2017 21:15:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 363 invoked by uid 89); 1 Mar 2017 21:15:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Leave, H*i:sk:C7261B2, H*f:sk:C7261B2, H*MI:sk:C7261B2 X-HELO: mail-wm0-f53.google.com Received: from mail-wm0-f53.google.com (HELO mail-wm0-f53.google.com) (74.125.82.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 01 Mar 2017 21:15:18 +0000 Received: by mail-wm0-f53.google.com with SMTP id n11so9568930wma.1 for ; Wed, 01 Mar 2017 13:15:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MHb4O/1670+hIs9qB66osxggEa5ThiiV2rJ5IoxyU/s=; b=AlDmRXsZKYbUyu4ZCn6LnDx8Ksij6pviYffjdFDmQaonV3SVN7nFJgmCoQyvpffDAa 82NF4gdkK/GV3psM3yThRjuaFx3VtVvyTThNvxLIw71WdrveJuplk5ZQJATT2axWcD/N VRZ+D9DFsS6J8OoL4qc9go8FGNzxp+frHOx2qQv1S994CTwW8ZBFa2KT2c34VKwFwjEZ lJapaDrzNU3gWkS9z3tqkBiSJQ1y8CcBMEojXj/kGwKscC6pMpImJdIZwpYNuDd8IWhI +1xyrfhN+nXus5A92UJhmrhey4YJ3My70xWGUMrBQ32PWxh4BlsJkvcalH4YC+rn1bLv KoLQ== X-Gm-Message-State: AMke39lYGdOpZFAAQ3s0wNRNr315OETgXHZy6BoqrS68jTcmih/k/hyPrciRuFxBEx/NtQ== X-Received: by 10.28.54.2 with SMTP id d2mr5006534wma.45.1488402913107; Wed, 01 Mar 2017 13:15:13 -0800 (PST) Received: from localhost ([2a02:c7d:8e39:c00:70f4:45a6:621d:bd0c]) by smtp.gmail.com with ESMTPSA id 186sm24249076wmw.24.2017.03.01.13.15.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Mar 2017 13:15:12 -0800 (PST) Date: Wed, 01 Mar 2017 21:15:00 -0000 From: Yao Qi To: Alan Hayward Cc: "Frank Ch. Eigler" , "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH] Remove MAX_REGISTER_SIZE from sol-thread.c Message-ID: <20170301211509.6h5xv66h2oeckarl@localhost> References: <9C2B8A71-1050-4B8B-A27A-C620E46AB9A2@arm.com> <86d1e0rkam.fsf@gmail.com> <20170301172400.GM7871@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20161104 (1.7.1) X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg00014.txt.bz2 On 17-03-01 18:35:36, Alan Hayward wrote: > > Reading both the 1998 patch and the code today, it looks to me like the > patch never adding anything. > Agreed. > > > If people are unsure, I???m happy to keep the code and replace the array > with std::vector (or anything else). > I believe your patch is correct. Leave this patch here for several days, if there is no other comments, you can push it in. -- Yao