From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17647 invoked by alias); 28 Feb 2017 14:50:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17498 invoked by uid 89); 28 Feb 2017 14:50:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,KHOP_DYNAMIC,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=canceled X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Feb 2017 14:50:33 +0000 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v1SEn4wP088952 for ; Tue, 28 Feb 2017 09:50:32 -0500 Received: from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110]) by mx0b-001b2d01.pphosted.com with ESMTP id 28wam8tc11-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 28 Feb 2017 09:50:31 -0500 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 28 Feb 2017 14:50:30 -0000 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp14.uk.ibm.com (192.168.101.144) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 28 Feb 2017 14:50:29 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id CE8B017D8056 for ; Tue, 28 Feb 2017 14:53:41 +0000 (GMT) Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v1SEoSRg10027378; Tue, 28 Feb 2017 14:50:28 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BD33C52052; Tue, 28 Feb 2017 13:49:03 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTPS id 9BEAB5204B; Tue, 28 Feb 2017 13:49:03 +0000 (GMT) From: Philipp Rudo To: gdb-patches@sourceware.org Cc: arnez@linux.vnet.ibm.com Subject: [PATCH 10/11] Remove unused deprecated_ui_load_progress_hook Date: Tue, 28 Feb 2017 14:50:00 -0000 In-Reply-To: <20170228145016.22604-1-prudo@linux.vnet.ibm.com> References: <20170228145016.22604-1-prudo@linux.vnet.ibm.com> X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17022814-0016-0000-0000-000004490880 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17022814-0017-0000-0000-0000269D2224 Message-Id: <20170228145016.22604-11-prudo@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-28_13:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1702280136 X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00720.txt.bz2 Nobody actually uses this hook anymore. So simply remove it. gdb/ChangeLog * defs.h (deprecated_ui_load_progress_hook): Remove. * symfile.c (deprecated_ui_load_progress_hook): Remove. (load_progress): Adjust. --- gdb/defs.h | 3 --- gdb/symfile.c | 7 +------ 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/gdb/defs.h b/gdb/defs.h index b7df0dc..e15ddf7 100644 --- a/gdb/defs.h +++ b/gdb/defs.h @@ -673,9 +673,6 @@ extern void (*deprecated_print_frame_info_listing_hook) (struct symtab * s, extern int (*deprecated_query_hook) (const char *, va_list) ATTRIBUTE_FPTR_PRINTF(1,0); -extern int (*deprecated_ui_load_progress_hook) (const char *section, - unsigned long num); - /* If this definition isn't overridden by the header files, assume that isatty and fileno exist on this system. */ #ifndef ISATTY diff --git a/gdb/symfile.c b/gdb/symfile.c index a749a2c..bc85c1b 100644 --- a/gdb/symfile.c +++ b/gdb/symfile.c @@ -65,8 +65,6 @@ #include "psymtab.h" -int (*deprecated_ui_load_progress_hook) (const char *section, - unsigned long num); void (*deprecated_show_load_progress) (const char *section, unsigned long section_sent, unsigned long section_size, @@ -1968,10 +1966,7 @@ load_progress (ULONGEST bytes, void *untyped_arg) args->buffer += bytes; totals->write_count += 1; args->section_sent += bytes; - if (check_quit_flag () - || (deprecated_ui_load_progress_hook != NULL - && deprecated_ui_load_progress_hook (args->section_name, - args->section_sent))) + if (check_quit_flag ()) error (_("Canceled the download")); if (deprecated_show_load_progress != NULL) -- 2.8.4