From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102123 invoked by alias); 23 Feb 2017 21:45:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 102045 invoked by uid 89); 23 Feb 2017 21:45:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-wm0-f68.google.com Received: from mail-wm0-f68.google.com (HELO mail-wm0-f68.google.com) (74.125.82.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Feb 2017 21:45:35 +0000 Received: by mail-wm0-f68.google.com with SMTP id v77so132523wmv.0 for ; Thu, 23 Feb 2017 13:45:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=LACFoyyI5hmottQkOeh68Q8kfnhRz5I9cmZMrEpmlBc=; b=YoXVpdzYf78EzidW12c1B9lAVmvh7ccVgY2TVHCJpL4x4XUffLLbxUZp3aNbPDmi5h a1QPmPm+Ggo6uHk28IWeE+gWekSK0jzwPMISeaFzXJ5O5TAouzBwy1uOORjHoQalHPDR XWDA3wm+PdDQN4V8NDJd8bRoKZksNtUxZ9A/lCJj745wP4QczHFbc2M4471f5NP8WH+B iaUYznlrc1VrmZqahmwzR3JaKNyVaTpMADj5wMmL5Deffn8eaZl3p2hKIQ3Aj0UVkDJz lq5j/9NRk/HZQliwuTlm7oggVM0K05sbSwkT7O/o0ftiWOmA2P5Tkix6ebO/idOOFnMT NoUQ== X-Gm-Message-State: AMke39mDbdAKkSFVagNWh+XroJ9mqB3wygFg2V+RE3Y18c2mF8hxGVSakO5qtxjlis+o/g== X-Received: by 10.28.107.84 with SMTP id g81mr7114481wmc.123.1487886333176; Thu, 23 Feb 2017 13:45:33 -0800 (PST) Received: from localhost ([2a02:c7d:8e39:c00:807f:455d:a156:a79e]) by smtp.gmail.com with ESMTPSA id x25sm7693383wrx.27.2017.02.23.13.45.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 Feb 2017 13:45:32 -0800 (PST) Date: Thu, 23 Feb 2017 21:45:00 -0000 From: Yao Qi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 1/2] symtab.c: Small refactor Message-ID: <20170223214525.bynt33cs4kylqayh@localhost> References: <86a89cc2u6.fsf@gmail.com> <1487870642-29926-1-git-send-email-palves@redhat.com> <1487870642-29926-2-git-send-email-palves@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1487870642-29926-2-git-send-email-palves@redhat.com> User-Agent: NeoMutt/20161104 (1.7.1) X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00652.txt.bz2 On 17-02-23 17:24:01, Pedro Alves wrote: > add_symtab_completions does the exact same as the code that it is > replacing. > > gdb/ChangeLog: > yyyy-mm-dd Pedro Alves > > * symtab.c (make_file_symbol_completion_list_1): Use > add_symtab_completions. Patch is good to me. -- Yao