From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112069 invoked by alias); 21 Feb 2017 10:55:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112043 invoked by uid 89); 21 Feb 2017 10:55:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=H*x:2.5, H*UA:2.5, H*x:version, H*UA:version X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Feb 2017 10:55:31 +0000 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v1LAsUJN122184 for ; Tue, 21 Feb 2017 05:55:29 -0500 Received: from e06smtp09.uk.ibm.com (e06smtp09.uk.ibm.com [195.75.94.105]) by mx0b-001b2d01.pphosted.com with ESMTP id 28rj2r5gjc-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 21 Feb 2017 05:55:29 -0500 Received: from localhost by e06smtp09.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 21 Feb 2017 10:55:27 -0000 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp09.uk.ibm.com (192.168.101.139) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 21 Feb 2017 10:55:26 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id F1C3F1B08023; Tue, 21 Feb 2017 10:58:24 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v1LAtPKV8716712; Tue, 21 Feb 2017 10:55:25 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F087F11C052; Tue, 21 Feb 2017 09:53:08 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DFF9011C04A; Tue, 21 Feb 2017 09:53:08 +0000 (GMT) Received: from oc3748833570.ibm.com (unknown [9.152.213.135]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 21 Feb 2017 09:53:08 +0000 (GMT) Received: by oc3748833570.ibm.com (Postfix, from userid 1000) id 933CED8313F; Tue, 21 Feb 2017 11:55:25 +0100 (CET) Subject: Re: [PATCH v3] [ppc64] Add POWER8/ISA 2.07 atomic sequences single-stepping support To: lgustavo@codesourcery.com Date: Tue, 21 Feb 2017 10:55:00 -0000 From: "Ulrich Weigand" Cc: emachado@linux.vnet.ibm.com (Edjunior Barbosa Machado), gdb-patches@sourceware.org In-Reply-To: from "Luis Machado" at Feb 20, 2017 01:52:13 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17022110-0036-0000-0000-00000370F0C9 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17022110-0037-0000-0000-0000152F9B50 Message-Id: <20170221105525.933CED8313F@oc3748833570.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-21_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1702210108 X-SW-Source: 2017-02/txt/msg00564.txt.bz2 Luis Machado wrote: > On 02/16/2017 05:42 PM, Edjunior Barbosa Machado wrote: > > What about gdb.arch/ppc64-isa207-atomic-inst.*? > > > > Could be. I don't have a better suggestion. Maybe Ulrich has. Not really ... the name looks good to me. > > +if {![istarget "powerpc*"] || ![is_lp64_target]} { > > + verbose "Skipping testing of powerpc64 single stepping over atomic sequences." > > untested "skipping powerpc isa 207 atomic sequences test"? Agreed, makes sense. > Otherwise i have no further comments. Thanks for the review, Luis! Edjunior, the patch is OK with the above change. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com