From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111828 invoked by alias); 19 Feb 2017 21:26:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111809 invoked by uid 89); 19 Feb 2017 21:26:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=tester, hammock, perfect X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 19 Feb 2017 21:26:48 +0000 Received: from smtp.corp.redhat.com (int-mx16.intmail.prod.int.phx2.redhat.com [10.5.11.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2EB5461BAA; Sun, 19 Feb 2017 21:26:48 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-116-221.ams2.redhat.com [10.36.116.221]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 071172D5EB; Sun, 19 Feb 2017 21:26:46 +0000 (UTC) Date: Sun, 19 Feb 2017 21:26:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org, Victor Leschuk , Sergio Durigan Junior Subject: Re: [PATCH 6/8] DWARF-5: call sites Message-ID: <20170219212643.GD1291@host1.jankratochvil.net> References: <148693097396.9024.2288256732840761882.stgit@host1.jankratochvil.net> <148693100920.9024.1248500668176010687.stgit@host1.jankratochvil.net> <0bcfa83d-33bf-14dd-6922-527913c76675@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0bcfa83d-33bf-14dd-6922-527913c76675@redhat.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00522.txt.bz2 On Fri, 17 Feb 2017 12:57:42 +0100, Pedro Alves wrote: > On 02/12/2017 08:23 PM, Jan Kratochvil wrote: > > --- a/gdb/testsuite/gdb.arch/amd64-entry-value-param.exp > > +++ b/gdb/testsuite/gdb.arch/amd64-entry-value-param.exp > > @@ -19,7 +19,7 @@ set opts {} > > if [info exists COMPILE] { > > # make check RUNTESTFLAGS="gdb.arch/amd64-entry-value-param.exp COMPILE=1" > > set srcfile ${srcfile2} > > - lappend opts debug optimize=-O2 > > + lappend opts optimize=-O2 additional_flags=-gdwarf-5 > > Did you mean to update the .S file? > > I wonder whether it makes sense to run the test twice, once against > the current .S file using the GNU version of the opcodes, and > another against standard DWARF5 opcodes. So I have added: gdb.arch/amd64-entry-value-param-dwarf5.exp It is not perfect as gdb.arch/amd64-entry-value-param-dwarf5.c there is the same as gdb.arch/amd64-entry-value-param.c . > That raises the question > of why we don't do that with the c based tests, where we'll handle > whatever format the compiler outputs. So maybe not go there... We do that, unaware if Sergio does that with buildbot but at least I do that with my GDB tester which I updated for DWARF-5: http://git.jankratochvil.net/?p=nethome.git;a=blob_plain;f=bin/hammock !defined $dwarf or ($dwarf>=2 && $dwarf<=5) or die "--dwarf requires DWARF version number"; Many years ago I was running the nightly testsuite runs for all DWARF versions. Nowadays I have at least regression tested this DWARF-5 patchset so that -gdwarf-4 and -gdwarf-5 do produce the same testsuite results. It has caught some bugs in my patchset. Jan