From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43812 invoked by alias); 16 Feb 2017 19:40:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43796 invoked by uid 89); 16 Feb 2017 19:40:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*MI:sk:463df71, H*f:sk:463df71, H*i:sk:463df71, policy X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Feb 2017 19:40:31 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 903FD3A769A; Thu, 16 Feb 2017 19:40:31 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-116-221.ams2.redhat.com [10.36.116.221]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1GJeS8b011204 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 16 Feb 2017 14:40:30 -0500 Date: Thu, 16 Feb 2017 19:40:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org, Victor Leschuk Subject: Re: [PATCH 1/8] Rename read_unsigned_leb128 to gdb_read_unsigned_leb128 Message-ID: <20170216194026.GA30138@host1.jankratochvil.net> References: <148693097396.9024.2288256732840761882.stgit@host1.jankratochvil.net> <463df715-da64-57a4-3237-99826918def1@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <463df715-da64-57a4-3237-99826918def1@redhat.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00449.txt.bz2 On Thu, 16 Feb 2017 16:23:51 +0100, Pedro Alves wrote: > Can't we just use bfd's version? bfd's version is in libbfd.c: /* Assorted BFD support routines, only used internally. and libbfd.h: /* libbfd.h -- Declarations used by bfd library *implementation*. (This include file is not for users of the library.) And I think GDB is a user of libbfd library. (One could argue libbfd should use visibility and/or C++ namespaces but for historical reasons libbfd does not use either.) I do not mind any solution, I have just complied with the libbfd policy. Jan