From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101963 invoked by alias); 8 Feb 2017 10:47:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 101947 invoked by uid 89); 8 Feb 2017 10:47:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.6 required=5.0 tests=BAYES_50,FREEMAIL_FROM,KAM_LOTSOFHASH,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=*regs, ULONGEST, ulongest, Removal X-HELO: mail-wm0-f68.google.com Received: from mail-wm0-f68.google.com (HELO mail-wm0-f68.google.com) (74.125.82.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Feb 2017 10:47:19 +0000 Received: by mail-wm0-f68.google.com with SMTP id c85so32540640wmi.1 for ; Wed, 08 Feb 2017 02:47:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=T2Ch8YrX1C2S8kJ6ejHvNc2qwm5STFvAUhHF6dh9b4Y=; b=NSDoh7e44VG5UWUIX6+puxgcS1CU1T4GH0JVYJSEDpfmomRv0WqKLDZeuO2plSOVzT VB/6juhzhTQWwkchSZSqIJzul1Rjc25AIQ5pmw3JVcYBpmmGHScXGVDWzEg3MTYbzDLf 7xkGoXuC88Ci53RWA9p3FuOhknTu7o5vJSKuuAPvQaaPFlhCzPTE/IPmtQ+okG8llkAb nLMEa5a+3/YDRkCF18+eGMBWb9KGvtfYZNT/4YTgNWXOZZrBkHXXJNfNMOGq/bU/9aOo +hu2LKFHvVgPolAOXNuaebU7FdvpWGCVWn9Om0Ltp79m5BtOi8fkyI4ej/lNpfpHxCYD iIRQ== X-Gm-Message-State: AMke39m4RUATtyq0FTXm93wltCSkKDrP7Ajjov+Yxt2zByMDcJuRgkrnaEmkehOnyQDdfg== X-Received: by 10.28.16.70 with SMTP id 67mr18539195wmq.142.1486550837398; Wed, 08 Feb 2017 02:47:17 -0800 (PST) Received: from E107787-LIN ([194.214.185.158]) by smtp.gmail.com with ESMTPSA id m188sm2664545wma.0.2017.02.08.02.47.15 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 08 Feb 2017 02:47:16 -0800 (PST) Date: Wed, 08 Feb 2017 10:47:00 -0000 From: Yao Qi To: Alan Hayward Cc: Pedro Alves , Joel Brobecker , "gdb-patches@sourceware.org" Subject: Re: [PATCH] Removal of uses of MAX_REGISTER_SIZE Message-ID: <20170208104713.GB32023@E107787-LIN> References: <20170202094012.dge4r6rsl2skdrii@adacore.com> <20170203102819.GA11916@E107787-LIN> <25716edf-096e-20c5-4170-fb8ca04d897b@redhat.com> <0C6A0D51-4C49-4400-8C46-E77DD512DF56@arm.com> <20170203165022.GB11916@E107787-LIN> <1E0030CE-FB37-4821-AA53-9C6D1CC285C9@arm.com> <20170206152635.GE11916@E107787-LIN> <5F3D30AE-9A53-493A-B6DC-DF594C2FAB18@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5F3D30AE-9A53-493A-B6DC-DF594C2FAB18@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00180.txt.bz2 On 17-02-07 16:33:19, Alan Hayward wrote: Hi Alan, We end up having multiple different ways removing MAX_REGISTER_SIZE, and each change is quite independent. I'll split it in my review, and you can to post a patch set in the next version. > diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c > index 8a4d59f6fdae8ec785462d0ceedcd6501b955cf0..081a16c6896ce7aee4db3b0be45fbbdd2c23dbdb 100644 > --- a/gdb/i386-tdep.c > +++ b/gdb/i386-tdep.c > @@ -3250,7 +3250,7 @@ i386_pseudo_register_read_into_value (struct gdbarch *gdbarch, > int regnum, > struct value *result_value) > { > - gdb_byte raw_buf[MAX_REGISTER_SIZE]; > + gdb_byte raw_buf[I386_MAX_REGISTER_SIZE]; > enum register_status status; > gdb_byte *buf = value_contents_raw (result_value); > > @@ -3455,7 +3455,7 @@ void > i386_pseudo_register_write (struct gdbarch *gdbarch, struct regcache *regcache, > int regnum, const gdb_byte *buf) > { > - gdb_byte raw_buf[MAX_REGISTER_SIZE]; > + gdb_byte raw_buf[I386_MAX_REGISTER_SIZE]; > > if (i386_mmx_regnum_p (gdbarch, regnum)) > { > @@ -5037,7 +5037,7 @@ i386_process_record (struct gdbarch *gdbarch, struct regcache *regcache, > uint32_t opcode; > uint8_t opcode8; > ULONGEST addr; > - gdb_byte buf[MAX_REGISTER_SIZE]; > + gdb_byte buf[I386_MAX_REGISTER_SIZE]; > struct i386_record_s ir; > struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); > uint8_t rex_w = -1; > diff --git a/gdb/i387-tdep.c b/gdb/i387-tdep.c > index adbe72133089bc371108d5dd79bf8d8e61ba259c..fcd5ad248d6b737b9f27e294ce166a118e4bdcad 100644 > --- a/gdb/i387-tdep.c > +++ b/gdb/i387-tdep.c > @@ -899,7 +899,7 @@ i387_supply_xsave (struct regcache *regcache, int regnum, > const gdb_byte *regs = (const gdb_byte *) xsave; > int i; > unsigned int clear_bv; > - static const gdb_byte zero[MAX_REGISTER_SIZE] = { 0 }; > + static const gdb_byte zero[I386_MAX_REGISTER_SIZE] = { 0 }; > enum > { > none = 0x0, > diff --git a/gdb/m68k-linux-nat.c b/gdb/m68k-linux-nat.c > index 6944c74eb198381135fda3ddf01b9da3a63e62d5..e5182caf39197f759c85c2321e4d66c428f5911e 100644 > --- a/gdb/m68k-linux-nat.c > +++ b/gdb/m68k-linux-nat.c > @@ -105,7 +105,7 @@ fetch_register (struct regcache *regcache, int regno) > struct gdbarch *gdbarch = get_regcache_arch (regcache); > long regaddr, val; > int i; > - gdb_byte buf[MAX_REGISTER_SIZE]; > + gdb_byte buf[M68K_MAX_REGISTER_SIZE]; Nit, we can even reduce the size of 'buf' to sizeof (long), because the code read/write register by PTRACE_PEEKUSER/PTRACE_POKEUSER which is word-wide operation. > int tid; > > /* Overload thread id onto process id. */ > @@ -160,7 +160,7 @@ store_register (const struct regcache *regcache, int regno) > long regaddr, val; > int i; > int tid; > - gdb_byte buf[MAX_REGISTER_SIZE]; > + gdb_byte buf[M68K_MAX_REGISTER_SIZE]; > > /* Overload thread id onto process id. */ > tid = ptid_get_lwp (inferior_ptid); This part is OK. -- Yao (齐尧)