From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54498 invoked by alias); 6 Feb 2017 15:52:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54469 invoked by uid 89); 6 Feb 2017 15:52:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Philipp, philipp, S390, Rudo X-HELO: mail-wm0-f65.google.com Received: from mail-wm0-f65.google.com (HELO mail-wm0-f65.google.com) (74.125.82.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Feb 2017 15:52:29 +0000 Received: by mail-wm0-f65.google.com with SMTP id c85so22683831wmi.1 for ; Mon, 06 Feb 2017 07:52:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=mFbnU7rk/Jg8vOb/vcyacUx69U0S6s5nBwvYR097bso=; b=t7N+ZlUdm3Jw+tWMhXIajgAqLNWLc/bi7JVB9uNKE+Z3R+sSIDzmnr3/3re2aIupDA jAvUWVPjUbihiO82lu6zY9LTJ16xQ7G3hjkCQy9w4AC8BOzszyQWZaT7KpkmkMutT/JS BIvvYRLiwdETcJa8hnr7skrq19Va/rcUqxNoIoXAUyCTm2usQ4j0cCkonQBN05/iYVqW gmwSa0EYZmLRsZGCRCe7HQx7RSI1ZSnsshRog2tfEWkh+6XOxYVPKWpWcS8Ah1dLejt1 IYH9ca3JNfWcAoVm/cVd4GyGP9XZARCRFugvDzr2Aq8gK5NdBmdZM61stOl++jHGI2kO ePdg== X-Gm-Message-State: AMke39mOYqJD77DaiX/0OzAKhgtjmF+1GqhGPfWJn3+Ms5ZRRnwdVeVdyLuB/8uk+C6aWA== X-Received: by 10.28.100.70 with SMTP id y67mr8661470wmb.45.1486396347517; Mon, 06 Feb 2017 07:52:27 -0800 (PST) Received: from E107787-LIN ([194.214.185.158]) by smtp.gmail.com with ESMTPSA id m29sm2144203wrm.38.2017.02.06.07.52.26 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 06 Feb 2017 07:52:26 -0800 (PST) Date: Mon, 06 Feb 2017 15:52:00 -0000 From: Yao Qi To: Luis Machado Cc: Philipp Rudo , gdb-patches@sourceware.org, peter.griffin@linaro.org, yao.qi@arm.com, arnez@linux.vnet.ibm.com Subject: Re: [RFC 7/7] Add S390 support for linux-kernel target Message-ID: <20170206155222.GF11916@E107787-LIN> References: <20170112113217.48852-1-prudo@linux.vnet.ibm.com> <20170112113217.48852-8-prudo@linux.vnet.ibm.com> <4afd49cd-534c-9f34-e389-6e4f6e686831@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4afd49cd-534c-9f34-e389-6e4f6e686831@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00121.txt.bz2 On 17-01-12 11:08:59, Luis Machado wrote: > On 01/12/2017 05:32 AM, Philipp Rudo wrote: > > > >diff --git a/gdb/s390-linux-tdep.c b/gdb/s390-linux-tdep.c > >index 054c6d5..f436a74 100644 > >--- a/gdb/s390-linux-tdep.c > >+++ b/gdb/s390-linux-tdep.c > > I wonder if we should put the new lk-specific code in its own file, > like s390-lk-tdep.c or something. It would make thing a bit more > clear and would pollute the current s390-linux-tdep.c file? > +1. -- Yao (齐尧)