From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120599 invoked by alias); 25 Jan 2017 16:26:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120246 invoked by uid 89); 25 Jan 2017 16:26:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy==e5=b0=a7, H*MI:sk:m3o9yw2, H*f:sk:m3o9yw2, H*i:sk:m3o9yw2?= X-HELO: mail-wm0-f66.google.com Received: from mail-wm0-f66.google.com (HELO mail-wm0-f66.google.com) (74.125.82.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Jan 2017 16:26:34 +0000 Received: by mail-wm0-f66.google.com with SMTP id r144so43635023wme.0 for ; Wed, 25 Jan 2017 08:26:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=q4f0UsyxgOP2iCkm3VgHnexhQi4BiotZwlumqtteRs4=; b=GcfHe1kZg+ksWlExgxlRi1DFsqBF+y2RQEhsmDws0cSLCK8Ihb3DLh4rl5hisxQy/d HsyugWErugAlt+dZzMCXjDDT1YXpivWDYsbGghaDf/vwSlWXLky8FnmSyb4eZygE8T1B AQI36kWkRq7RiGLSz+s5jLLGskLSrk85Z2p97/Y/MXn5ThnB1i8WylvqujMQek0VV4q8 n+hPbR9CWUb0aygMcuK4VB2LW83S8OqH0tmWExwGK0H+Udr7zagCAHAtEN3Mp/hVe4nT GjgdWCLCEa34SaBQl9Eteej/S1yPLIkkk0lfo5EZyLq5QcDy9tmCn/44Ob9VLazGaWnS VC3A== X-Gm-Message-State: AIkVDXI+CZV/wlzcTqrZFUqVjs2z/GZ1tlwmMUZb+KqM64O18Uu1hh0Ru8g7qaSA/2Nj5Q== X-Received: by 10.223.173.40 with SMTP id p37mr7548318wrc.136.1485361592423; Wed, 25 Jan 2017 08:26:32 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id w17sm25847794wra.28.2017.01.25.08.26.30 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 25 Jan 2017 08:26:31 -0800 (PST) Date: Wed, 25 Jan 2017 16:26:00 -0000 From: Yao Qi To: Andreas Arnez Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Use dwarf assembler in gdb.dwarf2/implptr-64bit.exp Message-ID: <20170125162612.GX28060@E107787-LIN> References: <1485250945-17594-1-git-send-email-yao.qi@linaro.org> <1485250945-17594-3-git-send-email-yao.qi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00540.txt.bz2 > > > + variable_label: variable { > > ...this causes FAILs on one of my systems unless replacing the > "variable" above by "DW_TAG_variable". Note that "variable" is a Tcl > command. > Fixed. > > + { name v } > > + { location { > > + DW_OP_implicit_value 0x1 0x1 0x1 0x1 > > + } SPECIAL_expr} > > + { type :$struct_label "DW_FORM_ref$ref_addr_size" } > > + } > > + > > + if { !$two_cu } { > > + subprogram { > > + { name main } > > + { low_pc main addr } > > + { high_pc "main+0x100" addr } > > + { type %$int_label } > > + { external 1 flag } > > + } { > > + variable { > > Same here. > > > diff --git a/gdb/testsuite/lib/dwarf.exp b/gdb/testsuite/lib/dwarf.exp > > index 1883c86..db51f5d 100644 > > --- a/gdb/testsuite/lib/dwarf.exp > > +++ b/gdb/testsuite/lib/dwarf.exp > > Looks OK to me as well, except a nit: > > > + switch -regexp -- $value { > > + {^0x[[:xdigit:]]{1}$} {_op .byte $value} > > + {^0x[[:xdigit:]]{2}$} {_op .byte $value} > > I'd rather replace the above two lines by a single one, to emphasize > that both cases are handled in the same way: > > {^0x[[:xdigit:]]{1,2}$} {_op .byte $value} > Fixed. I pushed these two patches in. -- Yao (齐尧)