From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14331 invoked by alias); 24 Jan 2017 15:33:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14275 invoked by uid 89); 24 Jan 2017 15:33:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=dis-asm.h, UD:dis-asm.h, =e5=b0=a7, Hx-languages-length:608?= X-HELO: mail-lf0-f67.google.com Received: from mail-lf0-f67.google.com (HELO mail-lf0-f67.google.com) (209.85.215.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 24 Jan 2017 15:33:11 +0000 Received: by mail-lf0-f67.google.com with SMTP id q89so17906636lfi.1 for ; Tue, 24 Jan 2017 07:33:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=9fU1/c6peEVVEZxfX0B7Tg9aKquZ+kYR4yKGtDan/oI=; b=VFGKGk9q0p2+9FnrogYPLAayzIlnwhSLRa0NfAjBv1/PeilKYw+7QgpwNbrOTYOF/p 7Dsnq7Voq+0mTO8Ym2JoqmXRSpZJQ3qK3mb0HqOfZxUb9eTFoU8895Np7SFaz6BHyasR j5O21TZ0jQQ8sFDD+EJKzrVzE+Ql9w4/MRNXWUnlu8JV+gEkFEvvpEPy7Bobo9EI+GN5 CAJ2l8AHkjn2ocib8Cls3v+1ijduULtkqmHQF4re8q8xkzZJgCJ3ZUP9E8T+Ku3FdmzM KIsCZLxr9frRGCiVMYw3xfXbldCRLKmfBrHsjFeatvCzoQvcEASYxA7Vk/kdsIMePf4s moNA== X-Gm-Message-State: AIkVDXJOq4ar/9DvbGd3tf4J0d4YRZ2NBiNJPFhg4ZCe7xBxAS/rxj5dQAxYEi814TEG8A== X-Received: by 10.223.172.107 with SMTP id v98mr28926416wrc.77.1485271988801; Tue, 24 Jan 2017 07:33:08 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id r5sm26679743wme.23.2017.01.24.07.33.06 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 24 Jan 2017 07:33:08 -0800 (PST) Date: Tue, 24 Jan 2017 15:33:00 -0000 From: Yao Qi To: Luis Machado Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 5/6] Disassembly unit test: memory error Message-ID: <20170124153249.GS28060@E107787-LIN> References: <1484051178-16013-1-git-send-email-yao.qi@linaro.org> <1484560977-8693-1-git-send-email-yao.qi@linaro.org> <1484560977-8693-6-git-send-email-yao.qi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00495.txt.bz2 On 17-01-17 08:37:48, Luis Machado wrote: > >+ > >+ static int read_memory (bfd_vma memaddr, gdb_byte *myaddr, > >+ unsigned int len, > >+ struct disassemble_info *info) > >+ { > >+ /* Always get an error. */ > > /* Always return an error. */ > > Also, should we return an explicit error like TARGET_XFER_E_IO or > MEMORY_ERROR? -1 is what target_read_code returned on error, and -1 is expected by disassembler in opcodes. We need to define the error number in include/dis-asm.h. I'll do it later. > > >+ return -1; > >+ } > >+ }; > >+ -- Yao (齐尧)