From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91941 invoked by alias); 24 Jan 2017 10:08:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91816 invoked by uid 89); 24 Jan 2017 10:08:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-spam-relays-external:209.85.213.66, H*RU:209.85.213.66, H*r:AES128-SHA X-HELO: mail-vk0-f66.google.com Received: from mail-vk0-f66.google.com (HELO mail-vk0-f66.google.com) (209.85.213.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 24 Jan 2017 10:08:27 +0000 Received: by mail-vk0-f66.google.com with SMTP id t8so13299683vke.0 for ; Tue, 24 Jan 2017 02:08:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=MaeWd6WpzG284ZaL/LyHzaL7E95UF4ryPNuG+F/svVI=; b=BP9u9lxdE50TiMPQmJDos29xKsXu2JGMX/bPl+C0jxnoCDs3zugU94JgyuvGK9TcJS cDPLPWdp/ApAwk85dp9LDmc9BX2Du84lOTp53RyRVETHmosWFxbWNJSMrv1Q9PJlj6pL jeG1BiW0Ezj7YCSQNNR5gqpCeUOYYKxrcg9xySYmZjT8wjlKVBI8Npoi3nJJd0MDIUPO 3tVKEOQKBdqPqWB61VkpVN4XZc0hAGzaB4n809/H3kXdGLRlvlwWH327YeEp9IssuaaA EBruwX9kTZ9SrqM3s5Go0nVGAjNCbc26ZlzEqsqeXn606YSRQuZLqmbFG4XDB67dp4Kk jWPw== X-Gm-Message-State: AIkVDXKg8HVYFWmcRTrHNOz7KZ2ZsnlF+P54yG9wxYAEIeqU3QqptXWvm57HuzasjZV4jQ== X-Received: by 10.223.170.137 with SMTP id h9mr27346613wrc.202.1485252505271; Tue, 24 Jan 2017 02:08:25 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id j18sm19080706wrb.33.2017.01.24.02.08.23 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 24 Jan 2017 02:08:24 -0800 (PST) Date: Tue, 24 Jan 2017 10:08:00 -0000 From: Yao Qi To: Luis Machado Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/6] Call print_insn_mep in mep_gdb_print_insn Message-ID: <20170124100805.GQ28060@E107787-LIN> References: <1484051178-16013-1-git-send-email-yao.qi@linaro.org> <1484560977-8693-1-git-send-email-yao.qi@linaro.org> <1484560977-8693-4-git-send-email-yao.qi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00491.txt.bz2 On 17-01-17 08:19:18, Luis Machado wrote: > On 01/16/2017 04:02 AM, Yao Qi wrote: > > > >-/* The mep disassembler needs to know about the section in order to > >- work correctly. */ > > Instead of removing the comment, should we point out what the > effects of having/not having section info will be? > That is the implementation detail of print_insn_mep (provided by opcodes), and gdb should not know about. Both gdb and objdump are the clients of opcodes, and they need to provide precise information as much as it can. However, they shouldn't know that what should print_insn_mep do. -- Yao (齐尧)