From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59671 invoked by alias); 24 Jan 2017 01:57:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58806 invoked by uid 89); 24 Jan 2017 01:56:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_05,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=commas, S390, max_len, ESA X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-pg0-f68.google.com Received: from mail-pg0-f68.google.com (HELO mail-pg0-f68.google.com) (74.125.83.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 24 Jan 2017 01:56:57 +0000 Received: by mail-pg0-f68.google.com with SMTP id t6so15137514pgt.1; Mon, 23 Jan 2017 17:56:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=J45DsEIAXkmvgPIdPsZunq5gY406yRdTFk1BLTRWMGI=; b=SLvfcfn0QkJAlPsC1dmAysaSbSQVx9r/vlSFGaB8pdoIEB8EqlGItdlKHZbzsZ+tQp Vb79KrhXePiRh2OLaA6y5dKE98rVN9v0bk4zEgNuRMBiOsY7CGS3EfkMQhtHMBRwCpBz /M1MPseb2dibGcAcVneMovUGMnb4IEFTTeZmY52P6k1F7nWys4fLBftSNZli/sMLZ9me 5yNrtNWF+zmUy5KWF+79EHFcclS01w/oaMuW+y/OFoHHt2X0HpFw1Fi4P1pcXSfh6+/T u/ZfXjE95Tt+iPPuRNEDH7Vt6wN15jXzrU4xNsNzeeOdVjc2s3F0+r2tCEsSMusY5U7z qYDA== X-Gm-Message-State: AIkVDXJ26m/a0DQbUwAFEVKXZKnvfjIEao3zHyM3GJ+3rqvTvDzMzc2FYzGL+peex1g54g== X-Received: by 10.84.238.205 with SMTP id l13mr47611532pln.168.1485223016484; Mon, 23 Jan 2017 17:56:56 -0800 (PST) Received: from bubble.grove.modra.org (CPE-58-160-71-80.tyqh2.lon.bigpond.net.au. [58.160.71.80]) by smtp.gmail.com with ESMTPSA id m21sm683029pgh.4.2017.01.23.17.56.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jan 2017 17:56:55 -0800 (PST) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 76356C0930; Tue, 24 Jan 2017 12:26:51 +1030 (ACDT) Date: Tue, 24 Jan 2017 01:57:00 -0000 From: Alan Modra To: Peter Bergner Cc: Pedro Alves , Eli Zaretskii , nickc@redhat.com, gdb-patches@sourceware.org, uweigand@de.ibm.com, binutils@sourceware.org Subject: Re: [PATCH 1/2] Add support for setting disassembler-options in GDB for POWER, ARM and S390 Message-ID: <20170124015651.GH28669@bubble.grove.modra.org> References: <83eg28dcjk.fsf@gnu.org> <019eaf5d-9ace-539e-8501-feb3cb0eed6c@vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-SW-Source: 2017-01/txt/msg00483.txt.bz2 On Mon, Jan 23, 2017 at 05:34:36PM -0600, Peter Bergner wrote: > The following S/390 specific disassembler options are supported for use\n\ > with the -M switch (multiple options should be separated by commas):\n")); > > - fprintf (stream, _(" esa Disassemble in ESA architecture mode\n")); > - fprintf (stream, _(" zarch Disassemble in z/Architecture mode\n")); > - fprintf (stream, _(" insnlength Print unknown instructions according " > - "to length from first two bits\n")); > + for (i = 0; sizeof (options) / sizeof (options[0]); i++) > + { > + unsigned int len = strlen (options[i].name); > + if (max_len < len) > + max_len = len; > + } > + > + for (i = 0, max_len++; sizeof (options) / sizeof (options[0]); i++) > + fprintf (stream, " %s%*c %s", > + options[i].name, > + (int)(max_len - strlen (options[i].name)), ' ', > + options[i].description); > } This appears to have lost translation of the help strings. -- Alan Modra Australia Development Lab, IBM